Review: Needs Fixing

Hello,

First of all, download_attachment_ids is not correctly defined. Function fields 
should always have a type and other parameters that come with their type. 
Moreover, you seem to be adding some kind of blob field holding various data 
about attachments, like a search + read field. This is not the way OpenERP 
works, especially that you already have some attachment ids already defined on 
the mail.message.

Concerning the issue related to accessing attachments, in chatter cliking on an 
attachment link should call a method on mail.message that will perform the 
various security checks/bypasses necessary to provide access to the attachment. 
This way, until we have a cleaner model for attachment management, every custom 
rule will be contained in the mail module without adding extra fields.
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-attachment-catch-error-chm/+merge/137163
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/trunk-attachment-catch-error-chm.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : openerp-dev-gtk@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to