Review: Needs Fixing
Runbot is red.
Please add tests *before* we merge it.
Methods _file_read, _file_write, _file_delete catch exceptions and *ignore*
them. You cannot do that! Logging exceptions is good, but not enough.
What is the purpose of parameter threshold in method _file_delete? Why would
you change its default value? Besides giving a hint to mess things up, I don't
see the point.
What about hash collisions?
In method _data_set:
- the case value=False is not handled properly;
- variables 'result' and 'bin_size' are not used;
- 'if path' -> 'if location', shouldn't it?
Field 'db_datas' is new, please give it a better name (like 'content'). And a
better description, too ('Database Data' applies to *any* field, just call it
'Content').
--
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-document-diet-al/+merge/109244
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openobject-server/trunk-document-diet-al.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : openerp-dev-gtk@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
