Review: Needs Fixing * The defered from the start _super call is lost * start() takes no parameters, no need to apply it * DOM events binding should use the events hash - incidentally, `click` handling has been broken, I'm pretty sure it's triggered on this.$el, not this. * The peppering of flag-checking seems… doubtful. Since the code is using $.get directly (an other doubtful idea) why not just abort() any in-flight request if there is one and change:effective_readonly is triggered? -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-fix-etherpad-chm/+merge/137507 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-fix-etherpad-chm.
_______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
