Review: Needs Fixing

Hello Amit,

I regret, but DB field size changed are not allowed for stable branch.
I would prefer you to strip the message according to the field size, to ensure 
it will fit into the DB. Something like:

procurement/procurement.py:387
    message_field_max_sz = max(0, 
self.pool.get('procurement.order')._all_columns['message'].column.size) or None
    cr.execute('update procurement_order set message=%s where id=%s', 
(message[:message_field_max_sz], procurement.id))

Regards,
Xavier
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/6.1-opw-583542-ado/+merge/141610
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/6.1-opw-583542-ado.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : openerp-dev-gtk@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to