Review: Disapprove

This error message is only a little better than the one it replaces. But worse, 
I think this is the wrong way to handle this problem. The database will already 
perform this check and raise an error if there is a problem. Rather than 
performing the check *again*, making the code more complicated, and wasting a 
lot of time with an extra database and running through the ORM, the error from 
PostgreSQL should be handled. Or better, the problem should be avoided entirely 
by means suggested in the bug report.
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-1102612-tta/+merge/144653
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/trunk-bug-1102612-tta.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : openerp-dev-gtk@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to