Review: Needs Fixing

This is broken, for instance the first test will match any "debug" anywhere in 
the url, if somebody creates a page served through a controller on /debug or 
the web client is embedded in a page whose URL contains the word "debug", it'll 
match and this bit will believe it is in debug mode somehow.

Considering we are already using jquery-bbq for query parameters manipulation, 
I would suggest learning the library and using it for this case as well, 
instead of doing the same thing by hand incorrectly.
-- 
https://code.launchpad.net/~openerp-dev/openerp-web/7.0-bug-1097757-ggh/+merge/145306
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openerp-web/7.0-bug-1097757-ggh.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : openerp-dev-gtk@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to