Review: Needs Fixing

in line 18 of the diff, you say

if 'hours' or 'user_id' in vals:

this is nasty as it always will be true, which will create a lot of bogus error 
messages to the user. the line should read

if 'hours' in vals or 'user_id' in vals
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/6.1-opw-575493-rha/+merge/108887
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/6.1-opw-575493-rha.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : openerp-dev-gtk@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to