Review: Disapprove

Hello,

I have re-analyzed the concept of Secondary currency again and found that the 
code should be as it is, this branch is useless, because setting same Secondary 
Currency as company currency is making no sense, Hence I am rejecting this 
branch, no doubt as end user point of view it seems an issue that if I am 
setting Secondary Currency as well as Invoice Currecny same then why it should 
raise constraint "The selected account of your Journal Entry forces to provide 
a secondary currency. You should remove the secondary currency on the account 
or select a multi-currency view on the journal." but Secondary currency must be 
used when you want force to make transaction in other currency then you company 
currency.

Here In account we have prevented to do this by code, so we can not consider it 
as a bug.

For details discussion on this, one can read the comments on following bugs.

https://bugs.launchpad.net/openobject-addons/+bug/925360
https://bugs.launchpad.net/openobject-addons/+bug/1015459

Thanks.
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/6.1-opw-583910-msh/+merge/144073
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/6.1-opw-583910-msh.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : openerp-dev-gtk@lists.launchpad.net
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to