Review: Needs Fixing * New code should avoid using Mochikit functions when possible, and use jQuery instead (hasElementClass, getNodeAttribute) * The call to self._is_event_droppable could probably go directly into the final TinyEvent call * In the templates, TinyEvent.droppable is accessed 6 times (I think) and every single time it's in a conditional to decide on the right class to set. Maybe TinyEvent should have an additional droppable_class property which would directly return the right class for the event, no?
-- https://code.launchpad.net/~openerp-dev/openobject-client-web/trunk-cal-events-readonly/+merge/39348 Your team OpenERP SA's Web Client R&D is requested to review the proposed merge of lp:~openerp-dev/openobject-client-web/trunk-cal-events-readonly into lp:openobject-client-web. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-web Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
