Review: Disapprove duplicate Hello, Thanks for the patch, the fix in domain_force_get() seems right, but the rest of it won't unfortunately cover all the cases. For example there could be empty rules that apply along with other non-empty rules, and in that case your dom_group will not be empty but dom_ORing might still not be appropriate.
Note that there is another branch from R&D that should fix the other cases and also adds appropriate YAML tests: https://code.launchpad.net/~openerp-dev/openobject-server/6.0-bug-719406-empty-record-rules-vmt/+merge/51522 It would be nice if you could review it and give your opinion there :-) PS: I'm closing this merge proposal as a duplicate -- https://code.launchpad.net/~openerp-dev/openobject-server/6.0-bug-719406-jvo/+merge/51367 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-server/6.0-bug-719406-jvo. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-web Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
