Review: Needs Fixing Hello your improvements for point (1) seems good but the changes made for the on_change part is not good
this will lead the client in a recursive call to server and results in a crash. this case will arise when only 1 field has on_change i.e no recursive on_changes. You should cover the cases like: Case 1: on_change on A on_change on B on_change on A ----> fills value for B resulting to fire on_change of B -------> fills value for C case 2: Normal on_change like currently we have on a single field resulting value of another field. eg: on_change on A ----------> fills value for B Please check this possibilities and make the changes accordingly. Thanks -- https://code.launchpad.net/~openerp-dev/openobject-client/trunk-improve_onchange-rga/+merge/59918 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-client/trunk-improve_onchange-rga. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-web Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
