Review: Needs Fixing 1. The bug report indicates this bug appears on 6.0.1, why not create a fix for 6.0 rather than trunk? 2. Please use "extend" to add complete iterables to lists, rather than "+=". It makes the behavior clearer (in that `+=` for lists is an in-place mutation, which is very different than `list = list + stuff`) 3. Please use `basestring` rather than `(str, unicode)` in isinstance checks. 4. If you just want to iterate on a sequence of iterables, why not use `itertools.chain`? 5. 'rpc2' is a terrible name -- https://code.launchpad.net/~openerp-dev/openobject-client-web/trunk-bug-753344-jra/+merge/58956 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-client-web/trunk-bug-753344-jra.
_______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-web Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
