Review: Needs Fixing Line 25 (of patch): no need to check the type of parent_names, it is already done at line 16 Line 27: assert must be used to check invariants (post conditions), not for checking validity of input. raise TypeError instead (like line 23) -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-factored-create-instance-vmt/+merge/62473 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-factored-create-instance-vmt.
_______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-web Post to : openerp-dev-web@lists.launchpad.net Unsubscribe : https://launchpad.net/~openerp-dev-web More help : https://help.launchpad.net/ListHelp
