Review: Approve I was also slightly annoyed by the refresh problem after modifying the uploaded CSV file, but initially thought it was a browser-specific behavior, i.e. choosing the same file again might be ignored by the browser as a non-event?
Otherwise everything looks good to me now, including the timezone handling/tests and support for NULL values. Great job Xavier, and thanks everyone for the feedback. @Carlos: supporting native excel import/export is something we'd like to add in the future indeed, but it's a little bit out of scope for the current implementation. But since the new import implementation is now very modular, you could easily override _str_to_float() and brutally hard-replace ',' with '.' in a custom module. That is, if you're not afraid of conflicts with thousands separators and possibly hiding errors that should have blocked the import. -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-newimport-phase2-xmo/+merge/126658 Your team OpenERP Framework Experts is requested to review the proposed merge of lp:~openerp-dev/openobject-server/trunk-newimport-phase2-xmo into lp:openobject-server. _______________________________________________ Mailing list: https://launchpad.net/~openerp-expert-framework Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-expert-framework More help : https://help.launchpad.net/ListHelp
