Hi. After a brief review, here are some more comments, with a batch of boring cosmetics commits, but while I was at reading the patches it was effortless to nitpick a bit.
On Tue, 18 Nov 2008 23:43:32 -0200 Daniel Ribeiro <[EMAIL PROTECTED]> wrote: > ezx/removefixup.diff 01 > ezx/mach/gpio.diff 02 The last hunk in gpio.diff is about missing GPIO defines in mfp-pxa2xx.h Submit that as a fix? It shouldn't need any review. > ezx/mach/keypad.diff 03 OK, signed-off-by: me > ezx/mach/i2c.diff 04 in e680_i2c_board_info we set also the addres for "lm4857", but there's no driver in mainline for this chip, we do have a first driver in our svn patchset tho. It could well stay as a placeholder, I just wanted to report > ezx/pcap.diff 05 > ezx/mach/pcap.diff 06 > ezx/mach/mci.diff 07 ok to these three > ezx/pcap_ts.diff 08 s/ezxts/pcap_ts/ in drivers/input/touchscreen/pcap_ts.c ? I want to hear your opinion before I change that. > ezx/mach/pcap_ts.diff 09 > ezx/pcap_leds.diff 10 > ezx/mach/pcap_leds.diff 11 > ezx/pcap_rtc.diff 12 > ezx/mach/pcap_rtc.diff 13 ok to these five > ezx/defconfig.diff 14 > How to update that? Split the edge master--ezx/defconfig and create a new ezx/defconfig_mainline branch? I'll try that later. Regards, Antonio -- A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? Web site: http://www.studenti.unina.it/~ospite Public key: http://www.studenti.unina.it/~ospite/aopubkey.asc
pgpO5sLjtnxyd.pgp
Description: PGP signature
