Hi Subhash, I reviewed the code and comments. Alex has responded to the comments and feels that this needs to be tested before merge. Since I don’t have the setup now, would you be able to test and let me know so that I can merge. I can help you with test guidelines if needed Please shoot me an e-mail offline.
Thanks Anandhi From: Subhash Singh [mailto:[email protected]] Sent: Friday, May 06, 2016 8:08 AM To: Manikantan, Anandhi <[email protected]> Cc: Alexis de Talhouët <[email protected]>; Jamo Luhrsen <[email protected]>; [email protected]; [email protected]; openflowplugin-dev <[email protected]>; Thanh Ha <[email protected]> Subject: Re: [release] [didm-dev] didm-hp module failing to compile Hello Anandhi, Could you please review the patch, as you are more familiar with this part of the implementation and also I don't have the rights to merge. -- Thanks and Regards, Subhash Kumar Singh On Fri, May 6, 2016 at 7:27 PM, Thanh Ha <[email protected]<mailto:[email protected]>> wrote: Thanks Alexis, Can someone review and merge the patch? Thanks, Thanh On 6 May 2016 at 08:45, Alexis de Talhouët <[email protected]<mailto:[email protected]>> wrote: And the candidate fix: https://git.opendaylight.org/gerrit/#/c/38507/ Thanks, Alexis On May 6, 2016, at 8:21 AM, Alexis de Talhouët <[email protected]<mailto:[email protected]>> wrote: FYI, this is the reason one DIDM is broken: changed of OFP yang model: https://git.opendaylight.org/gerrit/#/c/36559/5/model/model-flow-service/src/main/yang/flow-node-inventory.yang Thanks, Alexis On May 5, 2016, at 8:03 PM, Thanh Ha <[email protected]<mailto:[email protected]>> wrote: FYI we've disabled DIDM from autorelease-boron so that the job can continue testing until this bug is sorted out. Regards, Thanh On 5 May 2016 at 16:39, Thanh Ha <[email protected]<mailto:[email protected]>> wrote: To be clear it's the root cause of why we can't reproduce the failure locally since ofp hasn't been pushing to Nexus their latest artifacts. didm-hp will still fail to compile so we still need someone to look into why getTableFeature() is failing. Regards, Thanh On 5 May 2016 at 15:11, Jamo Luhrsen <[email protected]<mailto:[email protected]>> wrote: after more debugging with Thanh, we think the root cause is because openflowplugin's merge job started failing because of the http vs https issue when uploading artifacts to nexus. this patch in openflowplugin should fix that: https://git.opendaylight.org/gerrit/38436 JamO On 05/05/2016 11:38 AM, Subhash Singh wrote: > +[Anandhi] > > Hello Thanh, > > Anandhi is familiar with didm-hp module (using getTableFeature), I think she > could add clarification on this issue. > > -- > Regards, > Subhash Kumar Singh > > On Thu, May 5, 2016 at 11:46 PM, Thanh Ha > <[email protected]<mailto:[email protected]> > <mailto:[email protected]<mailto:[email protected]>>> > wrote: > > On 5 May 2016 at 00:31, Thanh Ha > <[email protected]<mailto:[email protected]> > <mailto:[email protected]<mailto:[email protected]>>> > wrote: > > Hi didm-devs, > > Autorelease has been failing since April 27th due to didm-hp module > failing to compile due to some unresolvable symbols (missing or changed > dependencies?). Can someone take a look? > > I opened bug 5843 to track this issue [0]. > > Regards, > Thanh > > [0] https://bugs.opendaylight.org/show_bug.cgi?id=5843 > > > > Hi Everyone, > > So taking a look at this closer with Jamo just now. We noticed that this > patch [0] in openflowplugin removed something that sounds like > getTableFeatures() but I'm not at all familiar with how yang maps to Java > so I could be wrong but could this be the cause of getTableFeatures() > being missing? > > If so how do we fix this? > > Regards, > Thanh > > [0] > https://git.opendaylight.org/gerrit/#/c/36559/5/model/model-flow-statistics/src/main/yang/opendaylight-flow-table-statistics.yang > > _______________________________________________ > didm-dev mailing list > [email protected]<mailto:[email protected]> > <mailto:[email protected]<mailto:[email protected]>> > https://lists.opendaylight.org/mailman/listinfo/didm-dev > > > > > _______________________________________________ > release mailing list > [email protected]<mailto:[email protected]> > https://lists.opendaylight.org/mailman/listinfo/release > _______________________________________________ release mailing list [email protected]<mailto:[email protected]> https://lists.opendaylight.org/mailman/listinfo/release
_______________________________________________ openflowplugin-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev
