We faced this problem before and that's the reason we decided to log the warning, but do not throw the exception. Robert patch again start throwing the exception and that's the reason we see all these exception. I think Robert patch is correct and it requires fix in the openflowplugin project itself, but i would suggest we should revert it till we fix that and put the respective bug on critical level to merge the patch again.
On Mon, May 23, 2016 at 7:07 AM, Shuva Jyoti Kar < [email protected]> wrote: > Thanks Josh, Sam. Sorry for all the inconvenience caused. > > > > The patch was just to catch the exception and log it, else its been thrown > up in the logs. Perhaps we need to log once for each of the multipart > reply(table features) > > > > Thanks > > Shuva > > *From:* Josh Hershberg [mailto:[email protected]] > *Sent:* Monday, May 23, 2016 7:16 PM > *To:* Shuva Jyoti Kar > *Cc:* Robert Varga; Sam Hague; [email protected] > *Subject:* Re: https://git.opendaylight.org/gerrit/#/c/39097/ breaks > netvirt > > > > Just proposed a revert ;-) > > > > On Mon, May 23, 2016 at 3:43 PM, Shuva Jyoti Kar < > [email protected]> wrote: > > Hi Josh, > > > > This is a cherry-pick from stable/beryllium to catch the > ClassCastException from being populated in the logs . Do I revert the fix ? > > > > Thanks > > Shuva > > > > *From:* Josh Hershberg [mailto:[email protected]] > *Sent:* Monday, May 23, 2016 7:08 PM > *To:* Robert Varga; Shuva Jyoti Kar; Sam Hague; > [email protected] > *Subject:* https://git.opendaylight.org/gerrit/#/c/39097/ breaks netvirt > > > > People, > > The commit in the subject caused a simple integration test to generate > 37,000 IllegalStateExceptions - thereby preventing the test from running > properly. Interestingly enough, if I remove the ClassCaseException from the > catch statement no IllegalStateExceptions are reported in the log and the > tests complete successfully. > > Good luck, > > Josh > > > > _______________________________________________ > openflowplugin-dev mailing list > [email protected] > https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev > > -- Thanks Anil
_______________________________________________ openflowplugin-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev
