Hi Shuva, Thanks for your valuable comments [😊] .
I replied your comments in Gerrit, please have a look, and suggest if any. Regards Senthil ________________________________ From: Shuva Jyoti Kar <[email protected]> Sent: Monday, October 24, 2016 8:56 PM To: Senthil Balachandran; [email protected] Cc: Abhijit Kumbhare Subject: RE: [openflowplugin-dev] Contribute to Openflowplugin Done. Please take care of the comments. The change-set looks good overall ☺ Br,shuva From: Senthil Balachandran [mailto:[email protected]] Sent: Monday, October 24, 2016 12:21 PM To: [email protected] Cc: Shuva Jyoti Kar; Abhijit Kumbhare Subject: Re: [openflowplugin-dev] Contribute to Openflowplugin Hi, Gentle reminder on the patch i have submitted. Thanks & regards Senthil ________________________________ From: Abhijit Kumbhare <[email protected]<mailto:[email protected]>> Sent: Tuesday, October 18, 2016 11:48 AM To: Senthil Balachandran Cc: Anil Vishnoi; Shuva Jyoti Kar; [email protected]<mailto:[email protected]>; Abhijit Kumbhare Subject: Re: [openflowplugin-dev] Contribute to Openflowplugin Good! On Monday, October 17, 2016, Senthil Balachandran <[email protected]<mailto:[email protected]>> wrote: Hi Shuva/Anil Thanks for your support. I have raised the patch please review it. Below is the link, https://git.opendaylight.org/gerrit/#/c/47047/ Note:There was some problem with our company proxy. Regards Senthil ________________________________ From: Anil Vishnoi <[email protected]> Sent: Tuesday, October 18, 2016 8:01 AM To: Shuva Jyoti Kar Cc: Senthil Balachandran; Abhijit Kumbhare; [email protected] Subject: Re: [openflowplugin-dev] Contribute to Openflowplugin Hi Senthil, You need gerrit user to push the patch. Following the below instructions https://wiki.opendaylight.org/view/OpenDaylight_Controller:Gerrit_Setup Thanks Anil On Mon, Oct 17, 2016 at 6:56 AM, Shuva Jyoti Kar <[email protected]> wrote: Hi Senthil, I follow the following steps, and these work for me : 1. git clone https://<user_id>@git.opendaylight.org/gerrit/openflowplugin<https://%[email protected]/gerrit/openflowplugin> 2. git checkout –b Bug-<bugId> 3. scp -p -P 29418 <user_id>@git.opendaylight.org:hooks/commit-msg .git/hooks/ 4. chmod 755 .git/hooks/commit-msg 5. git add <file_names> 6. git commit –s and add the commit message 7. git review Do let me know if it helps Thanks Shuva From: Senthil Balachandran [mailto:[email protected]] Sent: Monday, October 17, 2016 6:37 PM To: Shuva Jyoti Kar; Abhijit Kumbhare Cc: [email protected] Subject: Re: [openflowplugin-dev] Contribute to Openflowplugin Hi Shuva, Thanking you for providing us the opportunity. I followed the link [1], to raise a patch but i haven't success. In git-review -s command i did not get output or nothing, it get struck for long time. git-review version --> 1.24 (Ubuntu 15.04) So please help me on this. [1] https://wiki.opendaylight.org/view/GettingStarted:Pulling,_Hacking,_and_Pushing_All_the_Code_from_the_CLI Thanks & Regards Senthil ________________________________ From: Shuva Jyoti Kar <[email protected]> Sent: Saturday, October 15, 2016 10:24 AM To: Senthil Balachandran; Abhijit Kumbhare Cc: [email protected] Subject: RE: [openflowplugin-dev] Contribute to Openflowplugin Hi Senthil, Please raise a patch on the openflowplugin master for review. I donot think you require any rights for raising a patch. Do let us know in case you are facing any difficulties in doing so. Thanks Shuva From: Senthil Balachandran [mailto:[email protected]] Sent: Saturday, October 15, 2016 8:25 AM To: Abhijit Kumbhare; Shuva Jyoti Kar Cc: [email protected] Subject: Re: [openflowplugin-dev] Contribute to Openflowplugin Hi Abhijit/Shuva, Can you please update on this. Thanks & regards Senthil ________________________________ From: Senthil Balachandran Sent: Tuesday, October 11, 2016 6:27 PM To: Abhijit Kumbhare; Shuva Jyoti Kar Cc: Abhijit Kumbhare; [email protected] Subject: Re: [openflowplugin-dev] Contribute to Openflowplugin Hi Abhijit/Shuva, Thanks for your comments. We will look up, how to bring those as config parameters in openflowplugin.cfg file. Meanwhile if you can provide us the pushing rights we will commit the patch. Thanks & Regards Senthil ________________________________ From: Abhijit Kumbhare <[email protected]> Sent: Tuesday, October 11, 2016 12:55:18 AM To: Shuva Jyoti Kar Cc: Senthil Balachandran; Abhijit Kumbhare; [email protected] Subject: Re: [openflowplugin-dev] Contribute to Openflowplugin That's great news Senthil! Can you please also check up with Shuva on the patch he has to have the configuration knob for stats on/off? We can do all these configuration knobs in a common place - as mentioned by Shuva with openflowplugin.cfg. Shuva - does the openflowplugin.cfg have a REST interface? On Sun, Oct 9, 2016 at 12:10 AM, Shuva Jyoti Kar <[email protected]> wrote: Hi Senthil, Great!! It would be good if we could provide them as config parameters in openflowplugin.cfg file, so that they survive cluster reboots. Do let me know in case you have any questions. Thanks Shuva From: [email protected] [mailto:[email protected]] On Behalf Of Senthil Balachandran Sent: Sunday, October 09, 2016 9:05 AM To: Abhijit Kumbhare Cc: [email protected] Subject: Re: [openflowplugin-dev] Contribute to Openflowplugin Hi Abhijit/Openflowplugin-dev Team, As discussed in the last meeting (06/10/2016), please find below the details we would like to contribute to openflowplugin. LLDP_FLOOD_PERIOD and MULTIPART messages (statistics) is hard coded to 5 and 3 seconds. As it is hard coded we are unable to change this time period. Also it extremely affects the CPU performance when we do scaling of Openflow enabled switches. We gone through the source code and come up with the solution to change this time period dynamically by providing REST API’s for both the LLDP and statistics. Also in our testing we observed that, after changing the time period via REST API which we have developed, almost 60 to 80% of load reduction, and thus increase in the CPU performance. So please let us know the further steps for contributing the same. Thanks & Regards Senthil ________________________________ From: Senthil Balachandran Sent: Saturday, September 10, 2016 9:26 AM To: Abhijit Kumbhare Subject: Re: Contribute to Openflowplugin Hi Abhijit, Sure. What area are those in? LLDP and Multipart message time interval is hard coded right now, also we cannot change it. We provide REST API for the same to change this time period dynamically. Please let me know when is the next meeting, will share more details. Thanks & Regards Senthil ________________________________ From: Abhijit Kumbhare <[email protected]> Sent: Friday, September 9, 2016 10:10:16 PM To: Senthil Balachandran Subject: Re: Contribute to Openflowplugin That’s good to know. What area are those in? Can you share more details of those in the next OpenFlow plugin meeting? From: Senthil Balachandran <[email protected]> Date: Friday, September 9, 2016 at 4:48 AM To: Abhijit Kumbhare <[email protected]> Subject: Contribute to Openflowplugin HI Abhijit, We have some patches (tested well) to commit to Openflowplugin. I know that approval is needed. So, Please let me know the process for doing the same. Thanks & Regards Senthil _______________________________________________ openflowplugin-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev _______________________________________________ openflowplugin-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev -- Thanks Anil
_______________________________________________ openflowplugin-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev
