Hi,
Gentle reminder.
Thanks & Regards
Senthil
________________________________
From: Senthil Balachandran
Sent: Wednesday, November 9, 2016 8:39 PM
To: Jozef Bacigal; Shuva Jyoti Kar; Hema Gopalkrishnan
Cc: [email protected]
Subject: Re: New LLDP and Statistics API
Hi Jozef,
Thanks a lot for your comments.
We will take care of your comments in the upcoming patch.
Thanks & regards
Senthil
________________________________
From: Senthil Balachandran
Sent: Wednesday, November 9, 2016 4:40 PM
To: Shuva Jyoti Kar; Hema Gopalkrishnan
Cc: [email protected]
Subject: Re: New LLDP and Statistics API
Hi Hema/Shuva,
Thanks for doing recheck. Now the build is success.
Thanks & Regards
Senthil
________________________________
From: Senthil Balachandran
Sent: Tuesday, November 8, 2016 2:50 PM
To: Shuva Jyoti Kar; Hema Gopalkrishnan
Cc: [email protected]
Subject: Re: New LLDP and Statistics API
Hi Shuva/Hema,
The statistics patch [1] build is failed.
Maybe recheck will make the build SUCCESS?
[1] https://git.opendaylight.org/gerrit/#/c/48006/
Awaiting your response also for the merging the both patch to MASTER [😊] .
Thanks & regards
Senthil
________________________________
From: Senthil Balachandran
Sent: Monday, November 7, 2016 9:46 PM
To: Shuva Jyoti Kar; Hema Gopalkrishnan
Cc: [email protected]
Subject: Re: New LLDP and Statistics API
Hi Shuva,
Thanks again for your comments.
Addressed it (both the patches LLDP and Statistics), please have a look.
Regards
Senthil
________________________________
From: Shuva Jyoti Kar <[email protected]>
Sent: Monday, November 7, 2016 8:47 AM
To: Senthil Balachandran; Hema Gopalkrishnan
Cc: [email protected]
Subject: RE: New LLDP and Statistics API
Hi Senthil,
Have commented on your change. A few minor ones requested. Overall looks great!
Thanks,
Shuva
From: Senthil Balachandran [mailto:[email protected]]
Sent: Sunday, November 06, 2016 6:36 PM
To: Shuva Jyoti Kar; Hema Gopalkrishnan
Cc: [email protected]
Subject: Re: New LLDP and Statistics API
Hi Hema/Shuva,
Thanks a lot for doing recheck.
Please let us know the further feedback on the patch if any.
Thanks & Regards
Senthil
________________________________
From: Senthil Balachandran
Sent: Saturday, November 5, 2016 12:12 AM
To: Shuva Jyoti Kar; Hema Gopalakrishnan
Cc:
[email protected]<mailto:[email protected]>
Subject: New LLDP and Statistics API
Hi Shuva/Hema,
I have submitted a new separate patch "new API's of LLDP and statistics " as
per the comments provided in my previous patch [1].
Here below the link
1. https://git.opendaylight.org/gerrit/#/c/48005/ (lldp)
2. https://git.opendaylight.org/gerrit/#/c/48006/ (statistics)
Kindly please review it and provide your comments if any.
Note: I have abandoned my previous patch [1]
[1] (https://git.opendaylight.org/gerrit/#/c/47047/)
Things that we observed,
1. We downloaded the openflowplugin master branch and without any changes i
just ran "mvn clean install". But the build struck in
T E S T S
-------------------------------------------------------
Running org.opendaylight.odlparent.featuretest.SingleFeatureTest
2. I see your patch "https://git.opendaylight.org/gerrit/#/c/47843/";, but here
the build failed (not get struck) at the same Test case as above.
Also i noticed that you have done 'recheck', after that the build get
succeeded. (Kindly please let me know the procedure for rechecking, may be it
need for me [😊] )
3. Finally i observed that the two patches which i have pushed recently, one
of the build (distribution-check-carbon) is failed, i think other build
(verify-carbon) is running but get struck in the same test case for long time.
So kindly please help us to resolve the issue.
Thanks & regards
Senthil
_______________________________________________
openflowplugin-dev mailing list
[email protected]
https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev
