Super Yrineu ☺ From: Yrineu Rodrigues [mailto:[email protected]] Sent: Thursday, December 01, 2016 11:18 AM To: Shuva Jyoti Kar Cc: Jamo Luhrsen; Developers; [email protected]; [email protected] Subject: Re: [openflowplugin-dev] [nic-dev] ODL: NIC - Second flow replaces first flow
Hi Shuva and Jamo, I've applied some changes on FlowBuilder in order to fill all needed fields and ensure that the FlowID to be unique for each flow and now it's working fine. Thanks a lot, I really appreciate your attention! with regards, On Thu, Dec 1, 2016 at 1:50 AM, Shuva Jyoti Kar <[email protected]<mailto:[email protected]>> wrote: Thanks Jamo. Yrineu, we need to ensure that the flowid is unique for both the flows else it will result in an update/modification instead of create. Sorry havenot gone through your flow-builder yet. Please do let me know in case you require any help Thanks Shuva From: [email protected]<mailto:[email protected]> [mailto:[email protected]<mailto:[email protected]>] On Behalf Of Yrineu Rodrigues Sent: Thursday, December 01, 2016 8:30 AM To: Jamo Luhrsen Cc: Developers; [email protected]<mailto:[email protected]>; [email protected]<mailto:[email protected]> Subject: Re: [openflowplugin-dev] [nic-dev] ODL: NIC - Second flow replaces first flow Yep, makes sense Jamo, I'll make a deep investigation using wireshark some other debugging sessions into the code. BTW, I'll look at OFP flow creation to ensure that we're creating this flow using the right parameters. Thanks a lot, On Wed, Nov 30, 2016 at 9:36 PM, Jamo Luhrsen <[email protected]<mailto:[email protected]>> wrote: On 11/30/2016 02:03 PM, Yrineu Rodrigues wrote: > Hi OpenFlow Plugin team, > > We're facing a issue when we try to create two different flows for two > different nodes, it follows the Intent creation and > the results for each one: > > 1st Intent -- opendaylight-user@root>intent:add --from 00:00:00:00:00:01 --to > 00:00:00:00:00:02 -a ALLOW > > OFPST_FLOW reply (OF1.3) (xid=0x2): > cookie=0x1, duration=17.344s, table=0, n_packets=0, n_bytes=0, > priority=10000,arp actions=CONTROLLER:65535,NORMAL > cookie=0x1, duration=17.052s, table=0, n_packets=0, n_bytes=0, > priority=9500,dl_type=0x88cc actions=CONTROLLER:65535 > cookie=0x0, duration=1.979s, table=0, n_packets=0, n_bytes=0, > priority=9001,dl_src=00:00:00:00:00:01,dl_dst=00:00:00:00:00:02 actions=NORMAL > > ============================ > > 2nd Intent -- opendaylight-user@root>intent:add --from 00:00:00:00:00:02 --to > 00:00:00:00:00:01 -a ALLOW > > OFPST_FLOW reply (OF1.3) (xid=0x2): > cookie=0x1, duration=118.399s, table=0, n_packets=0, n_bytes=0, > priority=10000,arp actions=CONTROLLER:65535,NORMAL > cookie=0x1, duration=118.107s, table=0, n_packets=0, n_bytes=0, > priority=9500,dl_type=0x88cc actions=CONTROLLER:65535 > cookie=0x0, duration=2.136s, table=0, n_packets=0, n_bytes=0, > priority=9002,dl_src=00:00:00:00:00:02,dl_dst=00:00:00:00:00:01 actions=NORMAL > > ============================ > > As you can see, the flow regarding 1st Intent was removed after 2nd Intent > creation, maybe we need to change something > (priority, cookie, tableId, etc) to ensure that flows regarding Intent #2 > does not replace Intent #1 flows. Hi Yrineu, it should be that any change in match and/or action would let your flow be unique and both should show up. I did it with NB REST and ended up with this: OFPST_FLOW reply (OF1.3) (xid=0x2): cookie=0x0, duration=29.362s, table=0, n_packets=0, n_bytes=0, priority=1,ip,dl_src=00:00:00:00:00:01,dl_dst=00:00:00:00:00:02 actions=NORMAL cookie=0x0, duration=3.371s, table=0, n_packets=0, n_bytes=0, priority=1,ip,dl_src=00:00:00:00:00:02,dl_dst=00:00:00:00:00:01 actions=NORMAL when doing it with with restconf though, I do have one more factor that makes it unique; the flow-id in config store. I don't think you are dealing with that in your java flowbuilder stuff. Seems like something is amiss. You could sniff the OF traffic to your switch to see if there is a flow-delete coming down when you add your 2nd flow. just some thoughts. Thanks, JamO > PS: You can see the 'FlowBuilder' creation at this link > <https://github.com/opendaylight/nic/blob/master/of-renderer/src/main/java/org/opendaylight/nic/of/renderer/impl/IntentFlowManager.java>. > > Please, let me know if you need more info. > > Thanks in advance, > > -- > Yrineu Rodrigues > > Software Engineer > *SERRO* | www.serro.com<http://www.serro.com> <http://www.serro.com> > > > _______________________________________________ > nic-dev mailing list > [email protected]<mailto:[email protected]> > https://lists.opendaylight.org/mailman/listinfo/nic-dev > -- Yrineu Rodrigues Software Engineer SERRO www.serro.com<http://www.serro.com/> LinkedIn • Facebook • YouTube • Vimeo • Twitter @TeamSerro Disclaimer: This e-mail message contains information intended solely for the intended recipient and is confidential or private in nature. If you are not the intended recipient, you must not read, disseminate, distribute, copy or otherwise use this message or any file attached to this message. Any such unauthorized use is prohibited and may be unlawful. If you have received this message in error, please notify the sender immediately by email, facsimile or telephone and then delete the original message from your machine. San Francisco | Santa Clara | New York | Toronto | Mumbai | Pune -- Yrineu Rodrigues Software Engineer SERRO www.serro.com<http://www.serro.com/> LinkedIn • Facebook • YouTube • Vimeo • Twitter @TeamSerro Disclaimer: This e-mail message contains information intended solely for the intended recipient and is confidential or private in nature. If you are not the intended recipient, you must not read, disseminate, distribute, copy or otherwise use this message or any file attached to this message. Any such unauthorized use is prohibited and may be unlawful. If you have received this message in error, please notify the sender immediately by email, facsimile or telephone and then delete the original message from your machine. San Francisco | Santa Clara | New York | Toronto | Mumbai | Pune
_______________________________________________ openflowplugin-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev
