Hi all, if we decide to revert back to previous behavior I prepared a patch in stable/boron branch.
https://git.opendaylight.org/gerrit/#/c/48913/ Luis can you please run the test with this patch, to be sure it is working ? Jozef ________________________________________ Od: Luis Gomez <[email protected]> Odoslané: 2. decembra 2016 1:21 Komu: [email protected] Predmet: [openflowplugin-dev] Flows not showing in operational Hi all, Just want to bring this thread up front along with what we talked this morning. Basically the change of behavior introduced in https://git.opendaylight.org/gerrit/#/c/47138 to fix Bug 6917 is what put me on alert as now alien flows will not show in operational DS unless they are the result of an RPC call, and even in that case they disappear after a controller or switch reboot. This means the following flows will be hidden to ODL users: - Config DS flows failing the matching function: I posted a simple example in https://bugs.opendaylight.org/show_bug.cgi?id=7258 but some experimenter matches (nicira, etc..) for example are not supported by matching function today. - RPC flows after switch or controller restart. - Any flow introduced by user, other controller or by switch itself on the switch. This is not common but can happen and flows in operational help to debug situations like this. This is not a neglect-able impact so at least in Boron I think we should come back to old behavior and try to fix Bug 6917 other way. Still if the change of behavior is required by some use case we can set some config knob to switch it on. BR/Luis > On Nov 29, 2016, at 8:53 PM, Luis Gomez <[email protected]> wrote: > > And lets talk about this patch on next ofplugin call as I do not conceive a > controller not able to show all flows installed in the switches regardless of > who pushed them. Flows dictate forward behavior and therefore all of them are > relevant for users and applications. > > BR/Luis > > >> On Nov 29, 2016, at 7:58 PM, Shuva Jyoti Kar <[email protected]> >> wrote: >> >> Sure, would take into the bugs :) >> >> Thanks Luis >> >> -shuva >> >> -----Original Message----- >> From: Luis Gomez [mailto:[email protected]] >> Sent: Wednesday, November 30, 2016 9:00 AM >> To: Shuva Jyoti Kar >> Cc: Anil Vishnoi; [email protected] >> Subject: Re: OF Reconciliation >> >> Shuva, there is something weird here: if I configure flows via RPC and then >> I restart OF channel, the flows disappear from operational, I do not think >> this is good so this is why I opened a bug. Also personally I do not like >> the idea of not seen all flows present in the switch in the operational DS >> but that is another discussion. >> >> BR/Luis >> >>> On Nov 29, 2016, at 7:22 PM, Shuva Jyoti Kar <[email protected]> >>> wrote: >>> >>> >>> >>> -----Original Message----- >>> From: Luis Gomez [mailto:[email protected]] >>> Sent: Wednesday, November 30, 2016 4:24 AM >>> To: Shuva Jyoti Kar >>> Cc: Anil Vishnoi; [email protected] >>> Subject: Re: OF Reconciliation >>> >>> Extremely sorry Luis, had marked your email to reply, but failed to do so, >>> my bad :( >>> >>> If we are using rpc to provision a flow, the flowid would be present in the >>> device flow registry, hence you would get it in the operDS. >>> But if we go and provision a flow in the switch (using cli/switch restconf >>> etc) you would not. >>> This was changed as a part of Bug 6917 >>> (https://git.opendaylight.org/gerrit/#/c/47138/) since we were ending up in >>> a race between provisioning and stats polling. >>> >>> thanks >>> -shuva >>> >>> >>> So I guess this is a bug if nobody can explain the new behavior: >>> >>> https://bugs.opendaylight.org/show_bug.cgi?id=7268 >>> >>> I also reported another bug earlier this week about reporting flows in >>> operational: >>> >>> https://bugs.opendaylight.org/show_bug.cgi?id=7258 >>> >>> BR/Luis >>> _______________________________________________ openflowplugin-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev JozefBacigál Software Engineer Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia R&D centrum / Janka Kráľa 9 / 974 01 Banská Bystrica / Slovakia +421 908 766 972 / [email protected] reception: +421 2 206 65 114 / www.pantheon.sk [logo] _______________________________________________ openflowplugin-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev
