Hi Jozef/Shuva, Please update on this patch. Thanks & regards Senthil
________________________________ From: Senthil Balachandran Sent: Wednesday, November 30, 2016 8:22 AM To: jozef.baci...@pantheon.tech Cc: Hema Gopalakrishnan; Shuva Jyoti Kar; jenkins-releng Subject: Re: Change in openflowplugin[master]: Add new API's for LLDP Jozef, Gentle reminder. Thanks & Regards Senthil ________________________________ From: Senthil Balachandran Sent: Tuesday, November 22, 2016 11:19 PM To: jozef.baci...@pantheon.tech Cc: Hema Gopalakrishnan; Shuva Jyoti Kar; jenkins-releng Subject: Re: Change in openflowplugin[master]: Add new API's for LLDP Hi Jozef, I have addressed your comments. Please have a look. Thanks & Regards Senthil ________________________________ From: Gerrit Code Review <ger...@opendaylight.org> Sent: Friday, November 18, 2016 12:53 PM To: Senthil Balachandran Cc: Hema Gopalakrishnan; Shuva Jyoti Kar; jenkins-releng Subject: Change in openflowplugin[master]: Add new API's for LLDP >From Jozef Bacigal <jozef.baci...@pantheon.tech>: Jozef Bacigal has posted comments on this change. Change subject: Add new API's for LLDP ...................................................................... Patch Set 3: (2 comments) https://git.opendaylight.org/gerrit/#/c/48005/3/applications/lldp-speaker/src/main/yang/lldp-speaker.yang File applications/lldp-speaker/src/main/yang/lldp-speaker.yang: PS3, Line 43: leaf set-interval { : type int64; : description "Set LLDP_FLOOD_PERIOD"; : } "interval" not set-interval to avoid getSetInterval methods PS3, Line 51: leaf get-interval { : type int64; : description "Get LLDP_FLOOD_PERIOD"; : } make typedef in yang file and name it as "interval" and use it in both rpc's. If you name it as only interval not as get-interval or set-interval it will be more readable and you don't get methosts like "getSetInterval" which is not nice name :) -- To view, visit https://git.opendaylight.org/gerrit/48005 To unsubscribe, visit https://git.opendaylight.org/gerrit/settings Gerrit-MessageType: comment Gerrit-Change-Id: I959e151c1e0f11799617bc3ae679cfb7539e764a Gerrit-PatchSet: 3 Gerrit-Project: openflowplugin Gerrit-Branch: master Gerrit-Owner: Senthil B <senthi...@tataelxsi.co.in> Gerrit-Reviewer: Hema Gopalakrishnan <hema.gopalkrish...@ericsson.com> Gerrit-Reviewer: Jozef Bacigal <jozef.baci...@pantheon.tech> Gerrit-Reviewer: Senthil B <senthi...@tataelxsi.co.in> Gerrit-Reviewer: Shuva Jyoti Kar <shuva.jyoti....@ericsson.com> Gerrit-Reviewer: jenkins-releng <jenkins-rel...@opendaylight.org> Gerrit-HasComments: Yes
_______________________________________________ openflowplugin-dev mailing list openflowplugin-dev@lists.opendaylight.org https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev
