Just to keep in record. We discussed this in openflowplugin meeting and decided to add the config flag in the configuration file that user can modify as required before starting the controller. On the fly change for this option won't be supported.
On Thu, Mar 2, 2017 at 12:59 AM, Tomáš Slušný <[email protected]> wrote: > Hi Anil, > > > I think there is not point in adding it to .cfg file, because Single Layer > Serialization cannot be turned on/off during run. It needs to be set when > OpenFlowPlugin is initialized and cannot be changed after that point, > because it is replacing deserializers with our own in OpenFlowJava (this > can be possibly reverted, so this in not real problem) but also > StatisticsContext is created differently with SLS turned on and turned off, > so when changed, we would need to replace this context. So placing it in > openflow-provider-config.yang was only suitable option. > > > Regards, > > Tomas Slusny > > > ------------------------------ > *Od:* Anil Vishnoi <[email protected]> > *Odoslané:* 2. marca 2017 3:30 > *Komu:* Tai, Hideyuki > *Kópia:* Tomáš Slušný; [email protected]; > [email protected]; Abhijit Kumbhare > *Predmet:* Re: [openflowplugin-dev] [WEATHER] - Turn Single Layer > Serialization on by default > > Hi Tomas, > > I believe we need to provide a config knob in .cfg file so that user can > turn it on and off using .cfg file knob, rather than building the whole > project code. > > Thanks > Anil > > On Wed, Mar 1, 2017 at 2:16 PM, Tai, Hideyuki <[email protected]> > wrote: > >> Hi Tomas, >> >> >> >> Thank you for the clarification!!!!! >> >> >> >> Regards, >> >> Hideyuki Tai >> >> >> >> *From:* Tomáš Slušný [mailto:[email protected]] >> *Sent:* Wednesday, March 01, 2017 14:10 >> *To:* Tai, Hideyuki <[email protected]>; >> [email protected]; [email protected]; >> Abhijit Kumbhare <[email protected]> >> *Subject:* Re: [openflowplugin-dev] [WEATHER] - Turn Single Layer >> Serialization on by default >> >> >> >> By these RPC statistics compatibility services I mean all services >> registered in MdSalRegistrationUtils#registe >> rStatCompatibilityServices [0]. >> That means all RPCs defined in YANG files in package >> model/model-flow-statistics/src/main/yang [1] except RPCs defined in >> opendaylight-direct-statistics.yang [2] and >> opendaylight-flow-statistics.yang#get-aggregate-flow-statist >> ics-from-flow-table-for-given-match [3] in that package. >> >> >> >> Regards, >> >> Tomas Slusny >> >> [0] https://git.opendaylight.org/gerrit/gitweb?p=openflowplugin. >> git;a=blob;f=openflowplugin-impl/src/main/java/org/ >> opendaylight/openflowplugin/impl/util/MdSalRegistrationUti >> ls.java;h=aa11506cb3be7c4426183927627a183e8c3f3557;hb=refs/ >> heads/master#l146 >> [1] https://git.opendaylight.org/gerrit/gitweb?p=openflowplugin. >> git;a=tree;f=model/model-flow-statistics/src/main/yang;hb=HEAD >> [2] https://git.opendaylight.org/gerrit/gitweb?p=openflowplugin. >> git;a=blob;f=model/model-flow-statistics/src/main/yang/ >> opendaylight-direct-statistics.yang;h=1025692fe2a0 >> 4ae15dfb452dab1d87fd51b0127e;hb=HEAD >> [3] https://git.opendaylight.org/gerrit/gitweb?p=openflowplugin. >> git;a=blob;f=model/model-flow-statistics/src/main/yang/ >> opendaylight-flow-statistics.yang;h=68ab1b2d4d12cdae33fcd29 >> 92fcb3ef40a482849;hb=HEAD#l139 >> >> >> ------------------------------ >> >> *Od:* Tai, Hideyuki <[email protected]> >> *Odoslané:* 1. marca 2017 20:16 >> *Komu:* Tomáš Slušný; [email protected]; >> [email protected]; Abhijit Kumbhare >> *Predmet:* RE: [openflowplugin-dev] [WEATHER] - Turn Single Layer >> Serialization on by default >> >> >> >> Hi the OpenFlow Plugin project, >> >> >> >> After merging the patch, the OpenFlow plugin doesn't work on OpenFlow 1.0 >> by default, right? >> >> If my understanding on the change is correct, I think this is a big >> change to projects which depend on the OpenFlow plugin. >> >> >> >> For example, I think CSIT for VTN Manager would start to fail on tests >> after merging the patch (Gerrit 52356), since the CSIT has test cases on >> OpenFlow 1.0 switches. >> >> >> >> >> >> I have several questions here. >> >> >> >> Are there any ways to turn off the Single Layer Serialization without >> re-building the OpenFlow Plugin code? >> >> If yes, we can modify the VTN CSIT script to use the Multi Layer >> Serialization in order to avoid the failures in the CSIT. >> >> >> >> Does OpenFlow plugin support both approaches in the future releases? >> >> Or will one of them become deprecated in Nitrogen release? >> >> >> >> Does the OpenFlow plugin project plan to support OF 1.0 in the Single >> Layer Serialization approach? >> >> >> >> Best Regards, >> >> -- >> >> Hideyuki Tai >> >> Senior Software Engineer >> >> NEC Corporation of America >> >> Office: +1-408-844-1012 <+1%20408-844-1012> >> Cell: +1-408-784-2147 <+1%20408-784-2147> >> >> Email: [email protected] >> >> >> >> *From:* [email protected] [ >> mailto:[email protected] >> <[email protected]>] *On Behalf Of *Toma? >> Slu?ny >> *Sent:* Wednesday, March 01, 2017 00:38 >> *To:* [email protected] >> *Cc:* [email protected]; Abhijit Kumbhare < >> [email protected]> >> *Subject:* [openflowplugin-dev] [WEATHER] - Turn Single Layer >> Serialization on by default >> >> >> >> - *Description:* Single Layer Serialization will be turned on by >> default. For those who will want to revert back to Multi Layer >> Serialization, please follow the following guide: >> >> >> - https://wiki.opendaylight.org/view/OpenDaylight_OpenFlow_Plu >> gin:OF13%2B_Single_Layer_Serialization#Disabled >> >> <https://wiki.opendaylight.org/view/OpenDaylight_OpenFlow_Plugin:OF13%2B_Single_Layer_Serialization#Disabled> >> - After you will do above, recompile project and you can use Multi >> Layer Serialization again >> >> >> - *Reported By:* Tomas Slusny, Email: [email protected] >> - *Reported On:* Wednesday 2017-03-01 >> - *Links to patches:* >> >> >> - https://git.opendaylight.org/gerrit/#/c/52356/ >> >> >> - *Links to Documentation:* >> >> >> - https://wiki.opendaylight.org/view/OpenDaylight_OpenFlow_Plu >> gin:OF13%2B_Single_Layer_Serialization >> >> <https://wiki.opendaylight.org/view/OpenDaylight_OpenFlow_Plugin:OF13%2B_Single_Layer_Serialization> >> >> >> - *Expected date patches will be merged:* Thursday 2017-03-02 >> - *Links to Weather Wiki:* >> >> >> - https://wiki.opendaylight.org/view/Weather#OpenFlowPlugin_-_ >> Turn_Single_Layer_Serialization_on_by_default >> >> <https://wiki.opendaylight.org/view/Weather#OpenFlowPlugin_-_Turn_Single_Layer_Serialization_on_by_default> >> >> >> >> Tomáš*Slušný* >> >> Software Developer >> >> >> Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia >> R&D centrum / Janka Kráľa 9 / 974 01 Banská Bystrica / Slovakia >> +421 911 083 902 <+421%20911%20083%20902> / [email protected] >> reception: +421 2 206 65 114 / www.pantheon.tech >> >> [image: Image removed by sender. logo] >> >> >> >> _______________________________________________ >> openflowplugin-dev mailing list >> [email protected] >> https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev >> >> > > > -- > Thanks > Anil > > > > TomášSlušný > > Software Developer > > > Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia > R&D centrum / Janka Kráľa 9 / 974 01 Banská Bystrica / Slovakia > +421 911 083 902 <+421%20911%20083%20902> / [email protected] > reception: +421 2 206 65 114 / www.pantheon.tech > > [image: logo] > > > -- Thanks Anil
_______________________________________________ openflowplugin-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev
