Hi Tomas,
I have committed a new patch, and the jenkins has verified successul. Could you
please have a look at the code again, thank you.
LiGuosheng
SDN Nanjing Development Dept. Ⅰ/Wireline Product R&D Institute/Wireline Product
Operation Division
E: [email protected]
原始邮件
发件人： ＜[email protected]＞
收件人：李国胜10121395
抄送人： ＜[email protected]＞ ＜[email protected]＞
＜[email protected]＞ ＜[email protected]＞宦林英10042773
＜[email protected]＞ ＜[email protected]＞
日 期 ：2017年05月25日 19:31
主 题 ：Re: Re: Change in openflowplugin[master]: Bug 8253: Set-Field cannotaccept
vendor extension fields.
Hi Li,
oh nevermind, my mistake, group statistics only contains packet count and byte
count for buckets. Only group desc augmentation is additionally needed. Sorry
for confusion.
--------------------------------------------------------------------------------
Od: [email protected] ＜[email protected]＞
Odoslané: štvrtok, 25. mája 2017 10:53
Komu: Tomáš Slušný
Kópia: [email protected] [email protected]
[email protected] Jozef Bacigál [email protected]
[email protected] [email protected]
Predmet: 答复: Re: Change in openflowplugin[master]: Bug 8253: Set-Field can
notaccept vendor extension fields.
Hi Tomas
I feel confused about the set-field extensions for group-statistics-updated,
I can not find any action defined in or augmented to group-statistics-updated.
Could you please give some advise? Thanks in advance.
LiGuosheng
SDN Nanjing Development Dept. Ⅰ/Wireline Product R&D Institute/Wireline
Product Operation Division
E: [email protected]
Tomáš Slušný
Software Developer
PANTHEON technologies s.r.o.
Janka Kráľa 9, 974 01 Banská Bystrica
Slovakia
Tel / +421 220 665 111
MAIL / [email protected]
WEB / https://pantheon.tech
发件人： ＜[email protected]＞
收件人：李国胜10121395 ＜[email protected]＞
抄送人： ＜[email protected]＞ ＜[email protected]＞
＜[email protected]＞宦林英10042773 ＜[email protected]＞
＜[email protected]＞
日 期 ：2017年05月24日 16:05
主 题 ：Re: Change in openflowplugin[master]: Bug 8253: Set-Field can notaccept
vendor extension fields.
Yes it should be there even if SPTN does not need it I think. And also not only
for group-desc-stats-updated but also for group-statistics-updated to have
support for set-field extensions in all cases where it is possible to put this
extensions, what I believe is also in that 2 cases I mentioned.
Regards.
Tomas Slusny
--------------------------------------------------------------------------------
Od: [email protected] ＜[email protected]＞
Odoslané: streda, 24. mája 2017 9:58
Komu: [email protected]
Kópia: [email protected] [email protected] Jozef Bacigál
[email protected] [email protected] [email protected]
Tomáš Slušný
Predmet: 答复: Change in openflowplugin[master]: Bug 8253: Set-Field can not
accept vendor extension fields.
Thanks Tomas
At the beginning, openflowplugin-extension-general.yang contained the
augmentation for group-stats buckets,
the SPTN project did not need this augment at present, so I commented this
augment in Patch Set1:
//augment
"/odl-group-stats:group-desc-stats-updated/odl-group-stats:group-desc-stats/odl-group-stats:buckets/odl-group-stats:bucket/odl-group-stats:action/odl-group-stats:action/odl-group-stats:set-field-case/odl-group-stats:set-field"
{
// ext:augment-identifier
"general-aug-match-notif-group-desc-stats-updated-set-field"
// uses general-extension-list-grouping
//}
To make the code clean, I deleted the commented code in Patch Set3, if you
think this augment is needed, I will add it back.
LiGuosheng
SDN Nanjing Development Dept. Ⅰ/Wireline Product R&D Institute/Wireline
Product Operation Division
E: [email protected]
Tomáš Slušný
Software Developer
PANTHEON technologies s.r.o.
Janka Kráľa 9, 974 01 Banská Bystrica
Slovakia
Tel / +421 220 665 111
MAIL / [email protected]
WEB / www.pantheon.tech
发件人： ＜[email protected]＞
收件人：李国胜10121395
抄送人： ＜[email protected]＞ ＜[email protected]＞
＜[email protected]＞宦林英10042773 ＜[email protected]＞
＜[email protected]＞
日 期 ：2017年05月24日 14:53
主 题 ：Change in openflowplugin[master]: Bug 8253: Set-Field can not accept
vendor extension fields.
From Tomas Slusny ＜[email protected]＞:
Tomas Slusny has posted comments on this change.
Change subject: Bug 8253: Set-Field can not accept vendor extension fields.
........................................................................
Patch Set 3:
(1 comment)
https://git.opendaylight.org/gerrit/#/c/56653/3/extension/openflowplugin-extension-api/src/main/yang/openflowplugin-extension-general.yang
File
extension/openflowplugin-extension-api/src/main/yang/openflowplugin-extension-general.yang:
Line 203: }
Isn't also augmentation for group-stats buckets needed too?
--
To view, visit https://git.opendaylight.org/gerrit/56653
To unsubscribe, visit https://git.opendaylight.org/gerrit/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id25456d2b9008ec260ce81d3a459bdc471a69e49
Gerrit-PatchSet: 3
Gerrit-Project: openflowplugin
Gerrit-Branch: master
Gerrit-Owner: LiGuosheng ＜[email protected]＞
Gerrit-Reviewer: Abhijit Kumbhare ＜[email protected]＞
Gerrit-Reviewer: Anil Vishnoi ＜[email protected]＞
Gerrit-Reviewer: HuanLinying ＜[email protected]＞
Gerrit-Reviewer: Jozef Bacigal ＜[email protected]＞
Gerrit-Reviewer: Prasanna Huddar ＜[email protected]＞
Gerrit-Reviewer: Tomas Slusny ＜[email protected]＞
Gerrit-Reviewer: jenkins-releng ＜[email protected]＞
Gerrit-HasComments: Yes_______________________________________________
openflowplugin-dev mailing list
[email protected]
https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev
