On Fri, Jun 23, 2017 at 7:09 PM, Anil Vishnoi <[email protected]> wrote:
> On Fri, Jun 23, 2017 at 9:12 AM, Michael Vorburger <[email protected]> > wrote: > >> On Fri, Jun 23, 2017 at 5:45 PM, Luis Gomez <[email protected]> wrote: >> >>> +1, I do not think it is good idea to depend on a project it is not >>> active anymore. I will prepare a patch to replace >>> "odl-openflowplugin-flow-services-ui" by >>> "odl-openflowplugin-flow-services-rest" >>> in our OpenFlow CSIT. >>> >>> >>> On Jun 23, 2017, at 7:02 AM, Jozef Bacigál <[email protected]> >>> wrote: >>> >>> It is on you right now. I created a patch for them but nobody merged it >>> yet. We decide to remove dlux dependency from plugin. Try to write anyone >>> to merge the patch. >>> >>> Thank you and have a nice weekend <OutlookEmoji-😊.png> >>> >>> Jozef >>> ------------------------------ >>> *Od:* Vishal Thapar <[email protected]> >>> *Odoslané:* piatok, 23. júna 2017 15:53:56 >>> *Komu:* Jozef Bacigál; Shuva Kar >>> *Kópia:* [email protected]; openflowplugin-dev >>> @lists.opendaylight.org >>> *Predmet:* RE: [openflowplugin-dev] Genius karaf4 blocked on >>> Openflowplugin >>> >>> Thanks Jozef. What about dlux dependency? Genius also has a >>> odl-genius-ui feature, so depends on DLUX. >>> >>> Strong +1 from my side for all project to drop dependencies on DLUX ... >> >> AFAIK, those "dependencies" are typically not "real" dependencies (as in, >> no "code" in e.g. genius or netvirt actually really needs DLUX), we just >> have these "convenience" UI features everywhere. Those don't make much >> sense, IMHO - you don't need that. Install whatever you like, and then >> separately install DLUX - there's no need for those "composite" UI features >> many project have, IMHO. >> > +1 on removing dlux > > as a dependency. OpenFlowplugin defined those features because when > initially ODL was launch, most of the folks were doing hands on with > OpenFlowplugin and they needed dlux to see this in shiny UI, and i think > that's the reason folks started taking it as a common practise to add these > UI features. Some of the project loads mdsal-apidoc feature in the UI > features, which is good to have and gives a bare minimum GUI to users for > playing with the models. > I wouldn't even do that (UI feature with mdsal-apidoc) .. I meant this more generally than just for DLUX; the *-ui features in general, which many projects have, don't really make sense to me. If your project has its own UI, then have a ui feature. If it does not, then what's the point of having a *-ui feature which installs DLUX, mdsal-apidoc or XYZ? Your code doesn't "need" that, so there's no "dependency" there as all. If as an end-user, or down-stream packager, you want any such UI, you can always easily just feature:install it - there's no need for projects having "convenience composite UI features" - IMHO. > IFF someone does the required work for DLUX in Nitrogen, then great. If >> nobody does, then... well, nobody does, and that's that. Nitrogen ships >> with[OUT] DLUX. Life continues. >> > just FYI: It actually was just done in https://git.opendaylight.org/gerrit/#/c/59443/ > Long short short, I see that Vishal has removed the odl-genius-ui feature >> with its dependency on DLUX as part of >> >> https://git.opendaylight.org/gerrit/#/c/59298/ - and agree that's the >> right thing to do. >> >>> >>> Regards, >>> Vishal. >>> >>> *From:* Jozef Bacigál [mailto:[email protected] >>> <[email protected]>] >>> *Sent:* 23 June 2017 19:01 >>> *To:* Vishal Thapar <[email protected]>; Shuva Kar < >>> [email protected]> >>> *Cc:* [email protected]; [email protected] >>> aylight.org >>> *Subject:* Re: [openflowplugin-dev] Genius karaf4 blocked on >>> Openflowplugin >>> >>> Vishal, >>> >>> OFP karaf4 changes merged >>> >>> Jozef >>> ------------------------------ >>> *Od:* Jozef Bacigál <[email protected]> >>> *Odoslané:* piatok, 23. júna 2017 8:54:30 >>> *Komu:* Vishal Thapar; Shuva Kar >>> *Kópia:* [email protected]; openflowplugin-dev >>> @lists.opendaylight.org >>> *Predmet:* Re: [openflowplugin-dev] Genius karaf4 blocked on >>> Openflowplugin >>> >>> Yes we will most probably start with it after karaf4 migration >>> >>> That seems like a good plan ... ;-) >> >>> Jozef >>> ------------------------------ >>> *Od:* Vishal Thapar <[email protected]> >>> *Odoslané:* piatok, 23. júna 2017 8:52:11 >>> *Komu:* Jozef Bacigál; Shuva Kar >>> *Kópia:* [email protected]; openflowplugin-dev >>> @lists.opendaylight.org >>> *Predmet:* RE: [openflowplugin-dev] Genius karaf4 blocked on >>> Openflowplugin >>> >>> Not exactly related to this, but whatever happened to merging OFJ/OFP? I >>> remember seeing some mails and discussions during one of meetings. Is that >>> still on cards? >>> >>> Regards, >>> Vishal. >>> >>> *From:* Jozef Bacigál [mailto:[email protected] >>> <[email protected]>] >>> *Sent:* 23 June 2017 12:20 >>> *To:* Shuva Kar <[email protected]>; Vishal Thapar < >>> [email protected]> >>> *Cc:* [email protected]; openflowplugin-dev@li >>> sts.opendaylight.org >>> *Subject:* Re: [openflowplugin-dev] Genius karaf4 blocked on >>> Openflowplugin >>> >>> Shuva, >>> >>> Java is already merged <image001.png>and yes not all plugin-commiters >>> are of-java commiters :) >>> ------------------------------ >>> *Od:* Shuva Kar <[email protected]> >>> *Odoslané:* piatok, 23. júna 2017 8:45:28 >>> *Komu:* Vishal Thapar >>> *Kópia:* [email protected]; openflowplugin-dev >>> @lists.opendaylight.org >>> *Predmet:* Re: [openflowplugin-dev] Genius karaf4 blocked on >>> Openflowplugin >>> >>> OFJ has to push in first, so requesting OFJ committers (not all are same) >>> >>> Br,shuva >>> >>> On Fri, Jun 23, 2017 at 9:59 AM, Vishal Thapar < >>> [email protected]> wrote: >>> >>> Oops! 1 should be 59323. These are karaf4 patches for openflowjava and >>> openflowplugin, assuming committers are common on both. OFJava will need to >>> go in first. >>> >>> You can also track https://git.opendaylight >>> .org/gerrit/#/q/topic:odlparent200 to track your dependencies and check >>> if they’ve migrated or not yet. >>> >>> Regards, >>> Vishal. >>> >>> *From:* Shuva Kar [mailto:[email protected]] >>> *Sent:* 23 June 2017 09:57 >>> *To:* Vishal Thapar <[email protected]> >>> *Cc:* [email protected]; genius-dev@li >>> sts.opendaylight.org >>> *Subject:* Re: [openflowplugin-dev] Genius karaf4 blocked on >>> Openflowplugin >>> >>> Vishal, >>> >>> Both [1] and [2] are same, is there another Gerrit that you could point >>> me to? >>> >>> Br,shuva >>> >>> On Fri, Jun 23, 2017 at 9:32 AM, Vishal Thapar < >>> [email protected]> wrote: >>> >>> Hello OFP devs, >>> >>> Could someone get [1] and [2] merged? OpenflowPlugin is the only one >>> blocking Genius from migrating to karaf4 right now. >>> >>> Regards, >>> Vishal. >>> >>> [1] https://git.opendaylight.org/gerrit/#/c/59323/ >>> [2] https://git.opendaylight.org/gerrit/#/c/59324/ >>> >>> >>> >>> _______________________________________________ >>> openflowplugin-dev mailing list >>> [email protected] >>> https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev >>> >>> >>> >>> >>> >>> *Jozef Bacigál* >>> Senior Software Engineer >>> >>> *PANTHEON* *technologies s.r.o.* >>> Janka Kráľa 9, 974 01 Banská Bystrica >>> Slovakia >>> Tel / +421 220 665 111 >>> >>> *MAIL **/* [email protected] >>> *WEB **/* https://pantheon.tech >>> >>> >>> >>> *Jozef Bacigál* >>> Senior Software Engineer >>> >>> *PANTHEON* *technologies s.r.o.* >>> Janka Kráľa 9, 974 01 Banská Bystrica >>> Slovakia >>> Tel / +421 220 665 111 >>> >>> *MAIL **/* [email protected] >>> *WEB **/* https://pantheon.tech >>> >>> >>> >>> *Jozef Bacigál* >>> Senior Software Engineer >>> >>> *PANTHEON* *technologies s.r.o.* >>> Janka Kráľa 9, 974 01 Banská Bystrica >>> Slovakia >>> Tel / +421 220 665 111 >>> >>> *MAIL **/* [email protected] >>> *WEB **/* https://pantheon.tech >>> >>> >>> >>> Jozef Bacigál >>> Senior Software Engineer >>> >>> PANTHEON technologies s.r.o. >>> Janka Kráľa 9, 974 01 Banská Bystrica >>> Slovakia >>> Tel / +421 220 665 111 >>> >>> MAIL / [email protected] >>> WEB / https://pantheon.tech >>> >>> >>> _______________________________________________ >>> openflowplugin-dev mailing list >>> [email protected] >>> https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev >>> >>> >>> >>> _______________________________________________ >>> genius-dev mailing list >>> [email protected] >>> https://lists.opendaylight.org/mailman/listinfo/genius-dev >>> >>> >> >> _______________________________________________ >> openflowplugin-dev mailing list >> [email protected] >> https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev >> >> > > > -- > Thanks > Anil >
_______________________________________________ openflowplugin-dev mailing list [email protected] https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev
