On 21/01/2019 11:28, SOMASHEKHAR MANOHARA JAVALAGI wrote:
> Hi Anil

Hello,

> Referring to the comments of jira
> https://jira.opendaylight.org/browse/OPNFLWPLUG-1060
> 
>  
> 
> We have received two events for the same flow-id in below order.
> 
> ADD event:           ADD flow with priority = 9
> 
>  
> 
> UPDATE event :   DELETE flow with priority = 9
> 
>  
> 
>                               ADD flow with priority = 6.
> 
>  
> 
>  
> 
> But the UPDATE event is processed first before ADD event.
> 
> Which is first trying to DELETE flow which doesn't exist followed by
> adding both the flows, though we received DataTreeChangeNotification in
> proper order.
> 
>  
> 
> Earlier we were handling flow mod requests in JobQueueHandler of
> NodeConfiguratorImpl, which was ensuring ordered processing.
> 
> With recent changes, we are using
> org.opendaylight.yangtools.util.concurrent.QueuedNotificationManager for
> request queue handling, which in this case is not ensuring the order.

That is quite weird, because QueuedNotificationManager's sole purpose is
to deliver events in order (for the specified key).

Can you run this case with https://git.opendaylight.org/gerrit/79790 and
log:set trace
org.opendaylight.openflowplugin.applications.frm.nodeconfigurator.NodeConfiguratorImpl


This should show the order of enqueue/dispatch of events for each key.

Thanks,
Robert

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
openflowplugin-dev mailing list
[email protected]
https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev

Reply via email to