https://defect.opensolaris.org/bz/show_bug.cgi?id=18602

Jens Elkner <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
                   |                            |.de

--- Comment #18 from Jens Elkner <[email protected]> 2011-06-30 
19:45:07 UTC ---
Well, as far as I can see, the patch just adds a try/catch block at the wrong
place. Since an OOM can happen anywhere, the try/catch block[s] needs to be
placed at the thread boundaries. Actually these "catchers" are already in
place, but are catching Exceptions (i.e. no Throwables), only. The patch from
https://defect.opensolaris.org/bz/show_bug.cgi?id=18618 (once applied) will fix
it.

PS:
a) System.exit() is often an indication, that something is wrong with the
code/logic - good apps should not need it [outside of main(...)] ;-) 
b) next time 'diff -bu ...' would be nice for such simple changes - than one
can spot the changes more quickly

-- 
Configure bugmail: https://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
opengrok-dev mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/opengrok-dev

Reply via email to