Peter De Wachter <pdewacht at gmail.com> writes:

> This patch provides annotate support for RCS/CVS files.

Thanks, that's great! I tried out the patch, and it seems to work just
fine. Have you signed the contributor agreement? You'll have to do that
before we can check in the changes. Please see these pages for the
details:

http://opensolaris.org/os/about/sun_contributor_agreement/
http://opensolaris.org/os/about/faq/sca_faq/

> I'm not sure why opengrok didn't have this already, jrcs has
> everything that's needed.

I think we were misled by this paragraph in the javadoc for the Archive
class:

    You can also retreive revisions in such a way that each item is
    annotated with the version number of the revision in which it was
    last changed or added. To retrieve annotated text use:

        String versionNumber = "1.2";
        Line[] text = archive.getRevision(versionNumber);
        for(int i = 0; i < text.length(); i++)
            System.out.println(text[i].revision.version);

Even with the obvious typos fixed (most importantly, getRevision()
should take the annotate argument to get annotated lines), no version
numbers were returned. I'm glad you found an alternative way that
worked.

-- 
Knut Anders

Reply via email to