Lubos Kosco wrote: > can you have a look at review for > http://defect.opensolaris.org/bz/show_bug.cgi?id=2395 > residing here : > http://cr.opensolaris.org/~taz/webrev-2008-09-01-Bug_2395_Searching_fails_for_expressions_starting_by_lucene_special_chars/ > > the tedious thing is the help, I tried to be as close as possible to > http://lucene.apache.org/java/2_2_0/queryparsersyntax.html#Escaping%20Special%20Characters > I didn't provide a link to lucene, since it changes with new versions, > so only a general link is on the bottom ... > > the other thing is a "suggest feature" for usual use case where people > look for a string containing lucene special chars and don't escape it > (so opengrok now suggests enclosing in "" or help on escaping chars ;) )
Looks good to me, I found just these tiny issues: - Aido vs. Aida - I'd appreciate some whitespace characters around the string + operator in your changes in search.jsp. Cheers, Jakub
