Hello,
I have been trying to get OpenHPI to allow me to control the front panel
LEDs via the OEM LED controls using the IPMI plugin. According to
the December 20, 2005 SAIM-HPI-B.01.01-ATCA spec, the oem.body[] array
is supposed to be of length 6 rather than 7 for these type of controls.
A patch is below for comments.
Regards,
Drew Moseley
diff -rub openhpi-2.8.1-clean/plugins/ipmi/ipmi_controls.c
openhpi-2.8.1/plugins/ipmi/ipmi_controls.c
--- openhpi-2.8.1-clean/plugins/ipmi/ipmi_controls.c 2007-01-29
06:47:46.000000000 -0700
+++ openhpi-2.8.1/plugins/ipmi/ipmi_controls.c 2007-08-01 15:29:30.000000000
-0700
@@ -170,7 +170,6 @@
}
state->StateUnion.Oem.Body[4] = 0;
state->StateUnion.Oem.Body[5] = 0;
- state->StateUnion.Oem.Body[6] = 0;
state->StateUnion.Oem.MId = ATCAHPI_PICMG_MID;
state->StateUnion.Oem.BodyLength = 6;
state->Type = SAHPI_CTRL_TYPE_OEM;
@@ -568,8 +597,8 @@
dbg("state->StateUnion.Mid isn't
ATCAHPI_PICMG_MID");
return SA_ERR_HPI_INVALID_DATA;
}
- if (state->StateUnion.Oem.BodyLength != 7) {
- dbg("state->StateUnion.Oem.BodyLength(%d) != 7",
+ if (state->StateUnion.Oem.BodyLength != 6) {
+ dbg("state->StateUnion.Oem.BodyLength(%d) != 6",
state->StateUnion.Oem.BodyLength);
return SA_ERR_HPI_INVALID_DATA;
}
diff -rub openhpi-2.8.1-clean/plugins/ipmi/ipmi_controls.c
openhpi-2.8.1/plugins/ipmi/ipmi_controls.c
--- openhpi-2.8.1-clean/plugins/ipmi/ipmi_controls.c 2007-01-29
06:47:46.000000000 -0700
+++ openhpi-2.8.1/plugins/ipmi/ipmi_controls.c 2007-08-01 15:29:30.000000000
-0700
@@ -170,7 +170,6 @@
}
state->StateUnion.Oem.Body[4] = 0;
state->StateUnion.Oem.Body[5] = 0;
- state->StateUnion.Oem.Body[6] = 0;
state->StateUnion.Oem.MId = ATCAHPI_PICMG_MID;
state->StateUnion.Oem.BodyLength = 6;
state->Type = SAHPI_CTRL_TYPE_OEM;
@@ -568,8 +597,8 @@
dbg("state->StateUnion.Mid isn't
ATCAHPI_PICMG_MID");
return SA_ERR_HPI_INVALID_DATA;
}
- if (state->StateUnion.Oem.BodyLength != 7) {
- dbg("state->StateUnion.Oem.BodyLength(%d) != 7",
+ if (state->StateUnion.Oem.BodyLength != 6) {
+ dbg("state->StateUnion.Oem.BodyLength(%d) != 6",
state->StateUnion.Oem.BodyLength);
return SA_ERR_HPI_INVALID_DATA;
}
--
mailto:[EMAIL PROTECTED]
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Openhpi-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openhpi-devel
