I have a question regarding OH_RESOURCE_GET (Verifies that resource exists) versus OH_RESOURCE_GET_CHECK (Verifies that resource exists and has not failed) macro usage in resource relative functions in src/sahpi.c: what is the unwritten rule saying that a given function should use one or the other?
In my opinion, some functions currently use the wrong one - at least when applied to ATCA systems since ATCA resources are marked as failed when it's not possible to communicate with them anymore. Here is a list of the ones I think should use OH_RESOURCE_GET_CHECK instead of OH_RESOURCE_GET (There might be others): saHpiSensorEnableGet saHpiSensorEnableSet saHpiSensorEventEnableGet saHpiSensorEventEnableSet saHpiSensorEventMasksGet saHpiSensorEventMasksSet saHpiHotSwapStateGet Regards, Pierre ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Openhpi-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openhpi-devel
