Similar to the message earlier today, the following changes look like
they could be made in the snmp_bc plugin to address issue #1804512,
"Debug output occurring during normal operation". Please let me know if
you agree and want me to make these changes (or whether you'd prefer to
do so). For these, I know that they're in "#if 0" code, so it probably
doesn't matter too much, unless someone changes the #if in the future.
In addition, I have a question about snmp_bc_sel.c, line 586. Looking
at other snmp_bc_snmp_get calls, it appears that a return value which is
not SA_OK is indeed an error (and the err() macro is used), but the code
falls through at this point. Is that intentional? From what I can see,
an error is reported, but then execution continues.
--
Bryan Sutula <[EMAIL PROTECTED]>
=======================================================================
--- svn/SF/openhpi/plugins/snmp_bc/snmp_bc_sensor.c 2007-10-03
15:25:20.000000000 -0600
+++ sandbox/openhpi/plugins/snmp_bc/snmp_bc_sensor.c 2007-11-05
12:10:56.000000000 -0700
@@ -153,12 +153,12 @@
{ /* Debug section */
SaHpiTextBufferT buffer;
- err("Sensor=%s", rdr->IdString.Data);
+ dbg("Sensor=%s", rdr->IdString.Data);
oh_decode_sensorreading(working_reading,
rdr->RdrTypeUnion.SensorRec.DataFormat, &buffer);
- err(" Reading: %s.", buffer.Data);
+ dbg(" Reading: %s.", buffer.Data);
oh_decode_eventstate(working_state,
rdr->RdrTypeUnion.SensorRec.Category, &buffer);
- err(" Event State: %s\n", buffer.Data);
+ dbg(" Event State: %s\n", buffer.Data);
}
#endif
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Openhpi-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openhpi-devel
