To answer the question about > plugins/ipmidirect/ipmi_mc_vendor_intel.cpp: static unsigned char id_time > = 20; /*id_time = 20 seconds*/ This could just as easily be a #define or const, it doesn't change and would be reused for any replicated domain/handler instances. I made it a variable with the thought that someday that value could be optionally passed in to the Control. If that happened, then it would probably be desirable to move it out to the cIpmiControlIntelRmsLed class private data.
Andy -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Pierre Sangouard Sent: Thursday, December 27, 2007 5:07 AM To: [email protected] Subject: Re: [Openhpi-devel] Domains and handlers mishmash See answer below, Pierre > -----Original Message----- > From: [EMAIL PROTECTED] [mailto:openhpi-devel- > [EMAIL PROTECTED] On Behalf Of Anton Pak > Sent: Monday, December 24, 2007 14:34 > To: OpenHPI-devel > Subject: [Openhpi-devel] Domains and handlers mishmash > > Hello. > > As I can see, now domain architecture is above plug-ins. > The domain stanza is entity path pattern for resources owned by the domain. > I see there are following possibilities: > > 1) all plug-in instance resources are owned by single domain > 2) plug-in instance resource is owned by several domains > 3) some plug-in instance resources are owned by one domain, others > by > other domains > > Regular expressions in entity patterns allows possibilities described > above. > Plug-in instance does not know what domain/domains it belongs. > > Question 1) > There is domain parameter - auto-insert timeout. > How handler can set it if handler does not know about domain/domains > it > belongs? > ( in case 2 or in case 3) > > Question 2) > Should 'AutoInsertTimeout' parameter be moved from plug-in stanza > to domain stanza? > > > Also, I guess that using of non-const static variables may cause problems > in case > of several plug-in instances. There is only one instance of the plugin but several handlers. None of the variables below except from id_time (I'll let Andy answer for this one) is connected to any particular handler, in other words they are global to the plugin so there is no problem with them being static. > > The suspicious places in ipmidirect plug-in: > > plugins/ipmidirect/ipmi_mc_vendor.cpp:static int use_count = 0; > plugins/ipmidirect/ipmi_mc_vendor.cpp:static cThreadLock lock; > plugins/ipmidirect/ipmi_mc_vendor_intel.cpp: static unsigned char id_time > = 20; /*id_time = 20 seconds*/ > plugins/ipmidirect/thread.cpp:static pthread_key_t thread_key; > plugins/ipmidirect/thread.cpp:static cInit init; > > > Anton Pak > > ------------------------------------------------------------------------ - > This SF.net email is sponsored by: Microsoft > Defy all challenges. Microsoft(R) Visual Studio 2005. > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ > _______________________________________________ > Openhpi-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/openhpi-devel ------------------------------------------------------------------------ - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Openhpi-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openhpi-devel ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Openhpi-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openhpi-devel
