Hello Peter, Please see my comments inline.
Regards, PG ________________________________ From: Peter D Phan [mailto:[EMAIL PROTECTED] Sent: Friday, October 24, 2008 2:15 AM To: [email protected] Subject: Re: [Openhpi-devel] saHpiResourceFailedRemove() fails if only FRU cap is set PG, Coincidentally I have been looking at this API the last few days. HPI-B.02 spec page 59, 2nd sentence in Return Value section does not make sense to me. Anyway, this has been our thought ... [PG] Yes, the 2nd sentence is wrong. This needs to be corrected in the next HPI spec (may be as errata in HPI-B.03). (a) Resources that support "Simplified Hotswap Model" only has two states, NOT PRESENT and ACTIVE. These resources do not have PRESENT/FAILED state. [PG] The resourceFailed field in RPT is applicable for all types of FRU and non-FRU resources. Hence, the FRUs supporting simplified hot swap model can use this field to indicate the failure. The FRUs supporting simplified hotswap model (for example: fans, power supply) can fail and management module may not be able to determine the exact status. In this scenario, HPI implementation can set resourceFailed field and report the same using the resource failed event. Moreover "Managed hotswap model" does not explicitly specified any particular state to indicate the resource failure. The FRU supporting managed hotswap model uses the resourceFailed field to indicate the failure. (b) Since the SaHpiResourceFailedRemove() API is for resources that are FRUs and has ResourceFailed flag set. We have intepreted it to mean that this API is only for "Managed Hotswap" resources. [PG] HPI-B.02 spec page 33, 2nd para says that FRUs can use the resourceFailed flag to indicate the failure/recovery. HPI-B.02 spec does not says that only FRU supporting managed hotswap can report the failure using the resourceFailed flag. Or, am I misunderstanding something here? Would you elaborate to why this API also should work for Simplified Hotswap resources? Peter, Regards, -------------------------------------------------------------------------------------------- P. D. Phan IBM Austin -------------------------------------------------------------------------------------------- [cid:749151313@24102008-3784]Raghavendra PG ---10/23/2008 01:46:53 AM---Hello, Raghavendra PG <[EMAIL PROTECTED]> 10/23/2008 01:46 AM Please respond to [email protected] To "[email protected]" <[email protected]> cc Subject [Openhpi-devel] saHpiResourceFailedRemove() fails if only FRU cap is set Hello, SaHpiResourceFailedRemove() API removes the failed resource entry (rpt, rdr) on user request. This API (src/safhpi.c +596) checks the FRU capability and tries to get the hotswap state. If the resource supports simplified hotswap model, then FRU capability will be set and MANAGED_HOTSWAP capability will not be set. So, the get_hotswap() abi will fail for these resources. Hence, saHpiResourceFailedRemove() fails for resources which supports simplified hotswap model. The attached patch resolves this issue. This problem is tracked in openhpi tracker as bug #2188639. Regards, PG [attachment "resource_failed.patch" deleted by Peter D Phan/Austin/IBM] ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/_______________________________________________ Openhpi-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openhpi-devel
<<inline: graycol.gif>>
<<inline: ecblank.gif>>
------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________ Openhpi-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openhpi-devel
