Hi Shuah,

The hotswap events, except surprise extraction should have event severity set 
to INFORMATIONAL. 

This is according to the SAF HPI B.03 spec, section 7.9.1 (page 222).
"Hotswap events indicating normal state transitions are issued with a severity 
of SAHPI_INFORMATIONAL. Events that indicate a "surprise extraction" are issued 
with the severity set in the ResourceSeverity field of the RPT entry for the 
resource."

This change was done as part of fix to bug #2529314.

Regards,
PG

> -----Original Message-----
> From: [email protected] 
> [mailto:[email protected]] 
> Sent: Wednesday, March 25, 2009 8:42 PM
> To: [email protected]
> Subject: [Openhpi-svn] SF.net SVN: openhpi:[6966] 
> openhpi/trunk/plugins/oa_soap
> 
> Revision: 6966
>           
> http://openhpi.svn.sourceforge.net/openhpi/?rev=6966&view=rev
> Author:   shuah
> Date:     2009-03-25 15:12:22 +0000 (Wed, 25 Mar 2009)
> 
> Log Message:
> -----------
> Fix for [2711991       Critical events are marked informational]
> 
> Modified Paths:
> --------------
>     openhpi/trunk/plugins/oa_soap/oa_soap_server_event.c
>     openhpi/trunk/plugins/oa_soap/oa_soap_utils.c
> 
> Modified: openhpi/trunk/plugins/oa_soap/oa_soap_server_event.c
> ===================================================================
> --- openhpi/trunk/plugins/oa_soap/oa_soap_server_event.c      
> 2009-03-06 15:10:49 UTC (rev 6965)
> +++ openhpi/trunk/plugins/oa_soap/oa_soap_server_event.c      
> 2009-03-25 15:12:22 UTC (rev 6966)
> @@ -315,7 +315,7 @@
>  
>          /* For blades that do not support managed hotswap, 
> ignore power event */
>          if (!(rpt->ResourceCapabilities & 
> SAHPI_CAPABILITY_MANAGED_HOTSWAP)) {
> -             dbg("Ignoring the power event");
> +             dbg("Ignoring the power event for blade %d", 
> bay_number);
>               return SA_OK;
>       }
>  
> @@ -337,6 +337,7 @@
>                                                        SAHPI_FALSE);
>                       if (rv != SA_OK) {
>                               err("Failure in disabling 
> thermal sensors");
> +                             
> oa_soap_bay_pwr_status[bay_number -1] = SAHPI_POWER_OFF;
>                               return rv;
>                       }
>                       oa_soap_bay_pwr_status[bay_number -1] = 
> SAHPI_POWER_OFF;
> @@ -769,7 +770,8 @@
>                                                       
> EntityLocation -1] == 
>                                                       
> SAHPI_POWER_ON) {
>                       dbg("Ignore the blade status event from 
> the partner"
> -                         " blade which is POWER ON state");
> +                         " blade %d which is in POWER ON state",
> +                         status->bayNumber);
>                       return;
>               }
>                               
> @@ -791,7 +793,8 @@
>                       if ((rv != SA_OK) ||
>                           
> (thermal_response.bladeThermalInfoArray == NULL)) {
>                               err("getBladeThermalInfo failed 
> for blade or"
> -                                 "the blade is not in stable state");
> +                                 "the blade %d is not in 
> stable state",
> +                                 status->bayNumber);
>                               return;
>                       }
>  
> 
> Modified: openhpi/trunk/plugins/oa_soap/oa_soap_utils.c
> ===================================================================
> --- openhpi/trunk/plugins/oa_soap/oa_soap_utils.c     
> 2009-03-06 15:10:49 UTC (rev 6965)
> +++ openhpi/trunk/plugins/oa_soap/oa_soap_utils.c     
> 2009-03-25 15:12:22 UTC (rev 6966)
> @@ -495,7 +495,7 @@
>          event->event.EventType = SAHPI_ET_HOTSWAP;
>          /* TODO: map the timestamp of the OA generated event */
>          oh_gettimeofday(&(event->event.Timestamp));
> -        event->event.Severity = SAHPI_INFORMATIONAL;
> +        event->event.Severity = SAHPI_CRITICAL;
>  }
>  
>  /**
> 
> 
> This was sent by the SourceForge.net collaborative 
> development platform, the world's largest Open Source 
> development site.
> 
> --------------------------------------------------------------
> ----------------
> Apps built with the Adobe(R) Flex(R) framework and Flex 
> Builder(TM) are
> powering Web 2.0 with engaging, cross-platform capabilities. 
> Quickly and
> easily build your RIAs with Flex Builder, the 
> Eclipse(TM)based development
> software that enables intelligent coding and step-through debugging.
> Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
> _______________________________________________
> Openhpi-svn mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/openhpi-svn
> 
------------------------------------------------------------------------------
_______________________________________________
Openhpi-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openhpi-devel

Reply via email to