Lars - That change looks good to me. Perhaps Anton can shed some light on the next problem you ran into.
--michael > -----Original Message----- > From: Lars Wetzel [mailto:[email protected]] > Sent: Friday, June 11, 2010 1:59 PM > To: [email protected] > Subject: Re: [Openhpi-devel] regression in 'make distcheck' > > > Hi > > please find in the attachment the fix of the test case. If > you allow I will > commit the change. > Sorry I forget to change the test case properly. > > But now I run in the next problem. I don't know if this > problem occurs due to > a not clean environment in my system or it is a problem of > the Makefile. > > If Anton is online, can you give me a hint, please. > > Thanks and > Best regards > Lars > > > > make[2]: Entering directory > `/home/goofy/workspace/openhpi-trunk/openhpi-2.15.0/_build/marshal' > Making check in t > make[3]: Entering directory > `/home/goofy/workspace/openhpi-trunk/openhpi-2.15.0/_build/marshal/t' > make marshal_000 marshal_001 marshal_002 marshal_003 > marshal_004 marshal_005 > marshal_006 marshal_007 marshal_008 marshal_009 marshal_010 > marshal_011 > marshal_012 marshal_013 marshal_014 marshal_015 marshal_016 > marshal_017 > marshal_018 marshal_019 marshal_020 marshal_021 marshal_022 > marshal_023 > marshal_024 marshal_025 marshal_026 marshal_027 marshal_028 > marshal_029 > marshal_030 marshal_031 marshal_hpi_types_000 marshal_hpi_types_001 > marshal_hpi_types_002 marshal_hpi_types_003 marshal_hpi_types_004 > marshal_hpi_types_005 marshal_hpi_types_006 marshal_hpi_types_007 > marshal_hpi_types_008 marshal_hpi_types_009 marshal_hpi_types_010 > marshal_hpi_types_011 marshal_hpi_types_012 marshal_hpi_types_013 > marshal_hpi_types_014 marshal_hpi_types_015 marshal_hpi_types_016 > marshal_hpi_types_017 marshal_hpi_types_018 marshal_hpi_types_019 > marshal_hpi_types_020 marshal_hpi_types_021 marshal_hpi_types_022 > marshal_hpi_types_023 marshal_hpi_types_024 marshal_hpi_types_025 > marshal_hpi_types_026 marshal_hpi_types_027 marshal_hpi_types_028 > marshal_hpi_types_029 marshal_hpi_types_030 marshal_hpi_types_031 > marshal_hpi_types_032 marshal_hpi_types_033 marshal_hpi_types_034 > marshal_hpi_types_035 marshal_hpi_types_036 marshal_hpi_types_037 > marshal_hpi_types_038 marshal_hpi_types_039 marshal_hpi_types_040 > marshal_hpi_types_041 marshal_hpi_types_042 marshal_hpi_types_043 > marshal_hpi_types_044 marshal_hpi_types_045 marshal_hpi_types_046 > marshal_hpi_types_047 marshal_hpi_types_048 > make[4]: Entering directory > `/home/goofy/workspace/openhpi-trunk/openhpi-2.15.0/_build/marshal/t' > gcc -DHAVE_CONFIG_H -I. -I../../../marshal/t -I../.. -I > ../../../marshal > -I../../../include -I../../../utils -I../../utils -g -O2 -pthread > -I/opt/gnome/include/glib-2.0 > -I/opt/gnome/lib64/glib-2.0/include > -Wall -Wmissing-prototypes > -Wmissing-declarations > -Wstrict-prototypes -Wpointer-arith > -Wformat=2 > -Wformat-security -Wformat-nonliteral > -Wno-format-y2k > -Wcast-qual -Wcast-align -Wno-strict-aliasing > -fno-strict-aliasing -Wno-unused-value -D_GNU_SOURCE > -D_REENTRANT > -fexceptions -MT marshal_000.o -MD -MP -MF > .deps/marshal_000.Tpo -c -o > marshal_000.o ../../../marshal/t/marshal_000.c > ../../../marshal/t/marshal_000.c: In function ‘main’: > ../../../marshal/t/marshal_000.c:30: warning: implicit > declaration of function > ‘MarshalByteOrder’ > mv -f .deps/marshal_000.Tpo .deps/marshal_000.Po > if test ! -f connection.c -a ! -L connection.c; then \ > ln -s ../../../marshal/connection.c; \ > fi > gcc -DHAVE_CONFIG_H -I. -I../../../marshal/t -I../.. -I > ../../../marshal > -I../../../include -I../../../utils -I../../utils -g -O2 -pthread > -I/opt/gnome/include/glib-2.0 > -I/opt/gnome/lib64/glib-2.0/include > -Wall -Wmissing-prototypes > -Wmissing-declarations > -Wstrict-prototypes -Wpointer-arith > -Wformat=2 > -Wformat-security -Wformat-nonliteral > -Wno-format-y2k > -Wcast-qual -Wcast-align -Wno-strict-aliasing > -fno-strict-aliasing -Wno-unused-value -D_GNU_SOURCE > -D_REENTRANT > -fexceptions -MT connection.o -MD -MP -MF .deps/connection.Tpo -c -o > connection.o connection.c > gcc: connection.c: Datei oder Verzeichnis nicht gefunden <- > File or Directory > not found (is german, Lars) > > gcc: no input files > make[4]: *** [connection.o] Fehler 1 > make[4]: Leaving directory > `/home/goofy/workspace/openhpi-trunk/openhpi-2.15.0/_build/marshal/t' > make[3]: *** [check-am] Fehler 2 > make[3]: Leaving directory > `/home/goofy/workspace/openhpi-trunk/openhpi-2.15.0/_build/marshal/t' > make[2]: *** [check-recursive] Fehler 1 > make[2]: Leaving directory > `/home/goofy/workspace/openhpi-trunk/openhpi-2.15.0/_build/marshal' > make[1]: *** [check-recursive] Fehler 1 > make[1]: Leaving directory > `/home/goofy/workspace/openhpi-trunk/openhpi-2.15.0/_build' > make: *** [distcheck] Fehler 1 > > On Friday, 11. June 2010 21:08, Bishop, Michael (ISB > Linux/Telco) wrote: > > Lars - > > > > Anton has now applied his patch for the first 'make > distcheck' issue we > > were seeing. Please download top-of-trunk - and run: > > > > ./bootstrap > > ./configure > > ./make dist > > ./make distcheck > > > > to see the next issue in 'make distcheck', which may be > related to changes > > made to the sahpi_struct_utils.c file. See additional info below. > > > > The tracker number for this issue is: #3014969 > > > > Thanks. > > > > --michael > > > > Regards, > > Michael Bishop > > Enterprise Servers and Storage (ISB Linux/Telco) > > Hewlett-Packard Company > > 3404 E. Harmony Rd. Bldg. 5L, Post B7, Mailstop 42 > > Fort Collins, CO 80528-9599 > > Phone: 970-898-4393 > > E-Mail: [email protected] > > > > > -----Original Message----- > > > From: Bishop, Michael (ISB Linux/Telco) > > > Sent: Friday, June 11, 2010 10:23 AM > > > To: 'Lars Wetzel' > > > Cc: '[email protected]' > > > Subject: RE: [Openhpi-devel] regression in 'make distcheck' > > > > > > > > > Lars - > > > > > > After you have completed your merge of the dynamic_simulator > > > - you may want to look at the 'make distcheck' failure that > > > Anton and I are seeing. See below. > > > > > > Anton has a patch to get passed the first issue we saw with > > > "make distcheck'. However, there is another issue we are now > > > see when running the test: > > > sahpi_struct_utils_test.c > > > > > > This test fails at line 1619 - expecting a return value of > > > SA_ERR_HPI_INVALID_DATA - but instead gets SA_OK. > > > > > > This failure appears to be related to threshold values. I've > > > looked thru the recent changes and see that you made changes > > > to: sahpi_struct_utils.c on Mar 19 and Mar 12, 2010 > > > (revisions 7054 and 7052). I'm suspecting that these changes > > > are causing this test to fail. Now it may be that this is a > > > new bug - or it may be simply that the test itself needs to > > > be updated. I need you to take a look and see if your > > > changes are causing the 'make distcheck' failure as shown > > > below - and to recommend how to resolve this issue. > > > > > > Thanks for helping. > > > > > > --michael > > > > > > Regards, > > > Michael Bishop > > > Enterprise Servers and Storage (ISB Linux/Telco) > > > Hewlett-Packard Company > > > 3404 E. Harmony Rd. Bldg. 5L, Post B7, Mailstop 42 > > > Fort Collins, CO 80528-9599 > > > Phone: 970-898-4393 > > > E-Mail: [email protected] > > > > > > > -----Original Message----- > > > > From: [email protected] > [mailto:[email protected]] > > > > Sent: Thursday, June 10, 2010 4:58 PM > > > > To: [email protected] > > > > Subject: Re: [Openhpi-devel] regression in 'make distcheck' > > > > > > > > > > > > Shame on me! > > > > > > > > I added sahpixtca_enum_utils files in Makefile.am and > > > > utils/Makefile.am > > > > but not in utils/t/different_tests/Makefile.am. > > > > The attached patch resolves the issue. > > > > > > > > I am going to commit it in trunk after merge with new simulator. > > > > > > > > Well, after all make distcheck failed in another place. > > > > See the log below. > > > > > > > > --------------------------------- > > > > Control Num: 1 (1 hex) > > > > Control Output Type: LED > > > > Control Type: OEM > > > > ManufacturerId: Unknown > > > > ConfigData: Config Dat > > > > Default: > > > > ManufacturerId: Unknown > > > > BodyLength: 14 > > > > Body: Config Default > > > > DefaultMode: > > > > Mode: AUTO > > > > ReadOnly: TRUE > > > > WriteOnly: TRUE > > > > OEM: 0 > > > > > > > > Error! Testcase failed. Line=1619 > > > > Received error=SA_OK > > > > FAIL: sahpi_struct_utils_test > > > > PASS: sahpi_text_utils_test > > > > ==================== > > > > 1 of 12 tests failed > > > > ==================== > > > > make[5]: *** [check-TESTS] Error 1 > > > > make[5]: Leaving directory > > > > `/home/avpak/archives/2010/src/hpi/orig/openhpi/trunk/openhpi- > > > > 2.15.0/_build/utils/t/sahpi' > > > > make[4]: *** [check-am] Error 2 > > > > make[4]: Leaving directory > > > > `/home/avpak/archives/2010/src/hpi/orig/openhpi/trunk/openhpi- > > > > 2.15.0/_build/utils/t/sahpi' > > > > make[3]: *** [check-recursive] Error 1 > > > > make[3]: Leaving directory > > > > `/home/avpak/archives/2010/src/hpi/orig/openhpi/trunk/openhpi- > > > > 2.15.0/_build/utils/t' > > > > make[2]: *** [check-recursive] Error 1 > > > > make[2]: Leaving directory > > > > `/home/avpak/archives/2010/src/hpi/orig/openhpi/trunk/openhpi- > > > > 2.15.0/_build/utils' > > > > make[1]: *** [check-recursive] Error 1 > > > > make[1]: Leaving directory > > > > `/home/avpak/archives/2010/src/hpi/orig/openhpi/trunk/openhpi- > > > > 2.15.0/_build' > > > > make: *** [distcheck] Error 2 > > > > > > > > --------------------------------- > > > > > > > > > > > > Anton Pak > > > > > > > > > Everyone: > > > > > > > > > > I just tested: make distcheck > > > > > using the OpenHPI top-of-trunk - and there is a regression > > > > > > > > from the 2.14.1 > > > > > > > > > release. > > > > > > > > > > Normally, 'make distcheck' takes the openhpi source code > > > > > > > > .gz archive, > > > > > > > > > unpacks it, builds it, and runs unit tests on it, then > > > > > > > > builds another > > > > > > > > > archive. Its kind of a sanity check for openhpi - and is a > > > > > > > > tool we use > > > > > > > > > when releasing openhpi to make sure the source code archive > > > > > > > > is useable. > > > > > > > > > On 2.14.1 - 'make distcheck' runs to completion. No issues. > > > > > > > > > > But on the top-of-trunk - I get this error that looks like > > > > > > > > something to do > > > > > > > > > with ATCA support. > > > > > This problem is independent of the new code for Lars Wetzel's > > > > > dynamic_simulator. > > > > > > > > > > Anyone know how this problem was introduced? > > > > > > > > > > --michael > > > > > > > > > > > > > > > gcc -g -O2 -pthread -I/usr/include/glib-2.0 > > > > > > > > -I/usr/lib/glib-2.0/include > > > > > > > > > -Wall -Wmissing-prototypes -Wmissing-declarations > > > > > > > > -Wstrict-prototypes > > > > > > > > > -Wpointer-arith -Wformat=2 -Wformat-security > -Wformat-nonliteral > > > > > -Wno-format-y2k -Wcast-qual -Wcast-align -Wno-strict-aliasing > > > > > -fno-strict-aliasing -Wno-unused-value -D_GNU_SOURCE > -D_REENTRANT > > > > > -fexceptions -o epath_utils_test epath_utils_test.o > epath_utils.o > > > > > sahpi_enum_utils.o sahpiatca_enum_utils.o sahpi_event_encode.o > > > > > sahpi_event_utils.o sahpi_struct_utils.o sahpi_time_utils.o > > > > > > > > uid_utils.o > > > > > > > > > -pthread /usr/lib/libltdl.so -ldl -lssl -L/lib > > > > > > > > -lgthread-2.0 -lglib-2.0 > > > > > > > > > -lm -lpthread -luuid > > > > > sahpi_enum_utils.o: In function `oh_encode_entitytype': > > > > > > > > /root/openhpi-build/svn.ref.7095-build/openhpi/openhpi-2.15.0/ > > > > > > > > _build/utils/t/epath/sahpi_enum_utils.c:942: > > > > > undefined reference to `oh_encode_xtcahpientitytype' > > > > > sahpi_enum_utils.o: In function `oh_lookup_entitytype': > > > > > > > > /root/openhpi-build/svn.ref.7095-build/openhpi/openhpi-2.15.0/ > > > > > > > > _build/utils/t/epath/sahpi_enum_utils.c:798: > > > > > undefined reference to `oh_lookup_xtcahpientitytype' > > > > > collect2: ld returned 1 exit status > > > > > make[5]: *** [epath_utils_test] Error 1 > > > > > make[5]: Leaving directory > > > > > > > > `/root/openhpi-build/svn.ref.7095-build/openhpi/openhpi-2.15.0 > > > > /_build/utils/t/epath' > > > > > > > > > make[4]: *** [check-am] Error 2 > > > > > make[4]: Leaving directory > > > > > > > > `/root/openhpi-build/svn.ref.7095-build/openhpi/openhpi-2.15.0 > > > > /_build/utils/t/epath' > > > > > > > > > make[3]: *** [check-recursive] Error 1 > > > > > make[3]: Leaving directory > > > > > > > > `/root/openhpi-build/svn.ref.7095-build/openhpi/openhpi-2.15.0 > > > > /_build/utils/t' > > > > > > > > > make[2]: *** [check-recursive] Error 1 > > > > > make[2]: Leaving directory > > > > > > > > `/root/openhpi-build/svn.ref.7095-build/openhpi/openhpi-2.15.0 > > > > /_build/utils' > > > > > > > > > make[1]: *** [check-recursive] Error 1 > > > > > make[1]: Leaving directory > > > > > > > `/root/openhpi-build/svn.ref.7095-build/openhpi/openhpi-2.15.0/_build' > > > > > > > > make: *** [distcheck] Error 2 > > > > > > > > -------------------------------------------------------------- > > > > ---------------- > > > > > > > > > ThinkGeek and WIRED's GeekDad team up for the Ultimate > > > > > GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the > > > > > lucky parental unit. See the prize list and enter to win: > > > > > > > > http://p.sf.net/sfu/thinkgeek-promo___________________________ > > > > > > ____________________ > > > > > > > Openhpi-devel mailing list > > > > [email protected] > > > > https://lists.sourceforge.net/lists/listinfo/openhpi-devel > > > > > -------------------------------------------------------------- > ------------- > >--- ThinkGeek and WIRED's GeekDad team up for the Ultimate > > GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the > > lucky parental unit. See the prize list and enter to win: > > http://p.sf.net/sfu/thinkgeek-promo > > _______________________________________________ > > Openhpi-devel mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/openhpi-devel > > -- > ------------------------------- > Dipl. Wi.ing. > Lars Wetzel > Uttinger Str. 13 > 86938 Schondorf a. Ammersee > > Tel.: 0179-2096845 > Mail: [email protected] > > USt-IdNr.: DE181396006 > ------------------------------------------------------------------------------ ThinkGeek and WIRED's GeekDad team up for the Ultimate GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the lucky parental unit. See the prize list and enter to win: http://p.sf.net/sfu/thinkgeek-promo _______________________________________________ Openhpi-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openhpi-devel
