Thanks, Michael!
Somehow the man pages for hpiinv were not included in the patch file,
but I did them. So it is no problem to commit everything today.
Cheers,
Uli
________________________________
From: ext Bishop, Michael (ISB Linux/Telco)
[mailto:[email protected]]
Sent: Wednesday, June 16, 2010 10:42 PM
To: Kleber, Ulrich (NSN - DE/Munich)
Cc: '[email protected]'
Subject: RE: Patch for new option to support domains in clients
Uli --
I've been testing rev. 7110 with your patch for the OpenHPI
client enhancements. I've tested make, make distcheck, ran the hpitest
conformance tests, built/installed rpms, ran some of the clients, etc.
It all looks good - except I do not see an updated man page for hpiinv -
which is one of the client apps that you added the -D option to. Is the
man page for hpiinv in a separate patch?
Other than that - it looks good to commit. Please update/close
the ticket associated with this enhancement - and be sure to include the
svn revision number for this change in the text of the update. Thanks.
--michael
-----Original Message-----
From: Kleber, Ulrich (NSN - DE/Munich)
[mailto:[email protected]]
Sent: Monday, June 14, 2010 1:56 AM
To: [email protected]
Subject: [Openhpi-devel] Patch for new option to support
domains in clients
Hi,
please find attached the complete promised patch
introducing a new option for nearly all clients.
This is the fix for #3011456 Domain Support for Clients
and some more.
The principle of this new feature for the clients is
very easy, since all clients in the beginning
of their processing of the HPI session to work with. So
I just needed to add the new option
to the case statement and change the saHpiSessionOpen to
use the given value.
If the option is not given, the
SAHPI_UNSPECIFIED_DOMAIN_ID is used as before.
I supported that with an additional printout when debug
is specified.
More remarks to the patch:
- hpionIBMblade is not included, because it doesn't make
sense to do it for that client
- hpigensimdata is already done by Lars, when he
submitted the dynamic simulator
- hpiel.c didn't have a correct copyright statement.
Bryan checked with Renier Morales, so we can fix that.
- I corrected also the usage texts wherever some
existing options where missing in the usage text.
- I corrected also the man pages, and added there
existing options where they were missing.
- I added in the man pages in section "see also" a
reference to all other clients.
- I added a check for some other options requiring a
mandatory value. So in these case, the usage
text will be printed. See e.g. hpievents -t or hpifan
-s.
- In hpireset I added a test option, so I could test it
without reset in my ATCA shelf.
That option -q is not documented in usage, and will
exit the program just before reset would be
issued.
- In hpisettime I fixed also #3014386 hpisettime input
parameter check.
- In hpitop I fixed also 3014897 DIMI and FUMI options
do not work hpitop
I tested the patch with rev.7080 in a two shelf ATCA
system.
I checked this morning against review 7102, that the
patch still works. None of these files were
touched.
Please check the patch again and let me know about any
issues.
I would be happy to commit it to 2.15.0.
Cheers,
Uli
<<clients.domain.patch>>
------------------------------------------------------------------------------
ThinkGeek and WIRED's GeekDad team up for the Ultimate
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the
lucky parental unit. See the prize list and enter to win:
http://p.sf.net/sfu/thinkgeek-promo
_______________________________________________
Openhpi-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openhpi-devel
