Anton - I have no issue with what you are proposing here. Removing dependencies is good - as long the goal is to make things generally easier to use - and easier for us to manage build-wise.
The one thing I caution about is thoroughly testing the change. Running commands like make, make rpm, make dist, make distcheck - and running the hpitest suite on these kinds of changes will help to ensure that the change is carried through properly in all aspects of the OpenHPI build chain. Call me paranoid - but I don't want to spend another week dinking around with make distcheck - right before the next release. If something gets broken - it should be a lot easier to figure out the issue now - rather than later - when a lot more changes have been committed. Cheers, --michael > -----Original Message----- > From: Anton Pak [mailto:[email protected]] > Sent: Tuesday, July 13, 2010 3:52 AM > To: OpenHPI-devel > Subject: [Openhpi-devel] Proposal: remove libopenhpiutils > dependency on > libuuid > > > Hello! > > I have the following proposal: > > Currently libopenhpiutils depends on libuuid. > Working on OpenHPI base library for Windows > I have problems with libuuid there. > > Investigation shows that libopenhpiutils uses only > uuid_unparse function from this library. > See file utils/sahpi_struct_utils.c, function oh_build_resourceinfo. > > Also the usage of this function differs on Solaris and Linux > and we have #ifdefs there. > > The function uuid_unparse just prints SaHpiRptEntryT.ResourceInfo.Guid > (which is unsigned char[16]) as a 36-byte string (plus tailing '\0') > of the form like 1b4e28ba-2fa1-11d2-883f-b9a76. > > I guess it can be done internally with simple printf call or > small static > function. > After that there is no need for libuuid dependancy for libopenhpiutils > > What say? > > Just created feature request #3028899 for this. > > Anton Pak > > -------------------------------------------------------------- > ---------------- > This SF.net email is sponsored by Sprint > What will you do first with EVO, the first 4G phone? > Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first > _______________________________________________ > Openhpi-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/openhpi-devel > ------------------------------------------------------------------------------ This SF.net email is sponsored by Sprint What will you do first with EVO, the first 4G phone? Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first _______________________________________________ Openhpi-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openhpi-devel
