Looks good.
Several comments:
1) The name oHpiDomainEntryGet is not a telling name.
When one looks at it, he/she shall get that this is function
that allows to know about all domains baselib knows about.
However, I have to admit, I have no telling variant to propose. :)
2) Let's introduce new data structure (with host/port) and use it instead
of separate host/port parameters.
May be in the future we will extend this data structure with new
information.
For example with entity_root.
3) "starting with SAHPI_UNSPECIFIED_DOMAIN_ID, and read all defined domain
ids."
You mean starting with SAHPI_FIRST_ENTRY, right?
Anton Pak
On Wed, 03 Nov 2010 13:08:02 +0300, Kleber, Ulrich (NSN - DE/Munich)
<[email protected]> wrote:
> Hi,
> Currently there is no possibility for an OpenHPI user to know which
> domains are defined for his baselibrary, unless he reads and scans the
> openhpiclient.conf file. In addition now domains can be defined
> dynamically, so it may be important for a user to know the valid domain
> ids.
> This should be even possible when a session to the default domain cannot
> be opened.
>
> Therefore I propose to introduce a new function oHpiDomainEntryGet,
> which works similar to the saHpiDrtEntryGet, but uses instead of the DRT
> of a specified domain the list of domains known to the baselib.
> The function should also provide access to the definition data of that
> domain, that is location of the daemon.
>
> Here is the syntax proposal:
>
> SaErrorT SAHPI_API oHpiDomainEntryGet (
> SAHPI_IN SaHpiDomainIdT DomainEntry,
> SAHPI_OUT SaHpiDomainIdT *NextEntry,
> SAHPI_OUT SaHpiTextBufferT *daemonhost,
> SAHPI_OUT SaHpiUint16T *port
> );
>
> Like in saHpiDrtEntryGet, the user would walk the list of domains,
> starting with SAHPI_UNSPECIFIED_DOMAIN_ID, and read all defined domain
> ids.
> Parameter daemonhost and port are not necessary here, but this way we
> don't need another function oHpiDomainInfoGet to read daemonhost and
> port.
>
> This proposal implements feature request 3025777: Support for domain
> discovery:
> https://sourceforge.net/tracker/?func=detail&aid=3025777&group_id=71730&;
> atid=532254
>
> Please send comments asap, so I can start implementing it.
> Cheers,
> Uli
>
>
>
> ------------------------------------------------------------------------------
> Achieve Improved Network Security with IP and DNS Reputation.
> Defend against bad network traffic, including botnets, malware,
> phishing sites, and compromised hosts - saving your company time,
> money, and embarrassment. Learn More!
> http://p.sf.net/sfu/hpdev2dev-nov
> _______________________________________________
> Openhpi-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/openhpi-devel
------------------------------------------------------------------------------
Achieve Improved Network Security with IP and DNS Reputation.
Defend against bad network traffic, including botnets, malware,
phishing sites, and compromised hosts - saving your company time,
money, and embarrassment. Learn More!
http://p.sf.net/sfu/hpdev2dev-nov
_______________________________________________
Openhpi-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openhpi-devel
