Anton -- Unless there is a compelling need to fix this - other than just a desire to clean-up the code - I would suggest not fixing it - as it is likely some users would experience compatibility issues.
--michael Regards, Michael Bishop Enterprise Servers and Storage (ESS/Linux/FlexFabric) Hewlett-Packard Company 3404 E. Harmony Rd. Bldg. 5L, Post B7, Mailstop 42 Fort Collins, CO 80528-9599 Phone: 970-898-4393 E-Mail: [email protected] -----Original Message----- From: Anton Pak [mailto:[email protected]] Sent: Wednesday, December 15, 2010 9:56 AM To: OpenHPI-devel Subject: [Openhpi-devel] Need to discuss: Bug in saHpiSensorEventMasksGet() marshalling Hello! SaHpi.h defines aHpiSensorEventMasksGet() as: saHpiSensorEventMasksGet( IN SessionId, IN ResourceId, IN SensorNum, OUTNN *AssertEventMask, OUTNN *DeassertEventMask ); So a user provides pointers to assert/deassert mask and Base library fills it. I've found that saHpiSensorEventMasksGet() marshalling request includes that AssertEventMask and DeassertEventMask data. It means that assert/deassert mask variables provided by user are sent to daemon along with session id, resource id and sensor num. And 5 parameters are sent in request instead of 3 needed. But output parameters are not to be sent in request. They shall be obtained from the response. Fortunatelly Base Library and Daemon use the same marshalling code. Daemon gets these 5 params and uses only 3 of them. It raises a question: The backward binary compatibility will be broken if we fix it. Combination of new Base Lib and Old daemon will crash. Shall we fix it? Anton Pak ------------------------------------------------------------------------------ Lotusphere 2011 Register now for Lotusphere 2011 and learn how to connect the dots, take your collaborative environment to the next level, and enter the era of Social Business. http://p.sf.net/sfu/lotusphere-d2d _______________________________________________ Openhpi-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openhpi-devel ------------------------------------------------------------------------------ Lotusphere 2011 Register now for Lotusphere 2011 and learn how to connect the dots, take your collaborative environment to the next level, and enter the era of Social Business. http://p.sf.net/sfu/lotusphere-d2d _______________________________________________ Openhpi-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openhpi-devel
