On Mon, 2011-01-31 at 19:06 +0100, Ulrich Kleber wrote: > during fixing this bug I noticed that hpireset ignores most of its options. > > GCC 4.6 produces warnings for hpireset.c: > hpireset.c:64:9: warning: variable 'bopt' set but not used > [-Wunused-but-set-variable] > hpireset.c:63:9: warning: variable 'breset' set but not used > [-Wunused-but-set-variable] > > When looking to the code it is obvious that options d,c,o,n,s are stored in > those variables, > which then are never used. > > Does it now make sense to extend hpireset to those options (which means > implement power-down, > power-cycle, send-nmi, soft-OS-shutdown and reboot to service partition), > which probably > had been planned some years ago, when hpireset was started?
I'm in favor of the improvement if you have the time/energy. Bryan ------------------------------------------------------------------------------ The modern datacenter depends on network connectivity to access resources and provide services. The best practices for maximizing a physical server's connectivity to a physical network are well understood - see how these rules translate into the virtual world? http://p.sf.net/sfu/oracle-sfdevnlfb _______________________________________________ Openhpi-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openhpi-devel
