Hi Bryan, I have formatted the lines in the new code to <=80 columns, according to the project guidelines. Please find the attached patch for review and let me know if any comments.
Thanks& Regards, Hemantha Reddy ________________________________________ From: Sutula, Bryan (Open Source Program Office) Sent: Monday, February 07, 2011 5:48 PM To: [email protected] Subject: Re: [Openhpi-devel] Patch for bug Source Forge ID: 3109793(Populate Temperature Sensors) to review On Mon, 2011-02-07 at 06:42 +0000, Beecherla, Hemantha wrote: > I have fixed the bug Source Forge ID: 3109793(Populate Temperature > Sensors) and attached the patch(3109793.patch) file. > PFA patch and logs for review, and let me know the comments if any. Would you please try to format the new source code to be <= 80 columns according to the project guidelines listed here: http://openhpi.org/Developers and the http://openhpi.org/LinuxKernelCodingStyle linked from that page? I know that there are places where the current code does not meet that guideline, but it's helpful for maintenance if we try to correct these when we can, and avoid adding new code with long lines. Thanks, Bryan ------------------------------------------------------------------------------ The modern datacenter depends on network connectivity to access resources and provide services. The best practices for maximizing a physical server's connectivity to a physical network are well understood - see how these rules translate into the virtual world? http://p.sf.net/sfu/oracle-sfdevnlfb _______________________________________________ Openhpi-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openhpi-devel
3109793.patch
Description: 3109793.patch
------------------------------------------------------------------------------ The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________ Openhpi-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openhpi-devel
