Hello Hemantha, The changes are looking good, but for the below one minor change.
- The char* buf pointer defined in oa_soap_callsupport.c:soap_login() is not free()'ed upon successful return. You should also free() before the error return at two places. 1. after the soap_message call. 2. error return at the end of function. Thanks, Elango -----Original Message----- From: Beecherla, Hemantha Sent: Monday, March 14, 2011 2:38 AM To: [email protected]; [email protected] Subject: [Openhpi-devel] Patch for Bug ID:3203038 "Remove the usage of the "poisoned" snprintf from OA SOAP plugin" to review Hi , I have fixed the Source forge Bug, Bug ID:3203038 "Remove the usage of the "poisoned" snprintf from OA SOAP plu<http://sourceforge.net/tracker/?func=detail&aid=3203038&group_id=71730&atid=532251>". Please find attached the patch for review and also please let us know the review comments if any. Thanks & Regards, Hemantha Reddy ------------------------------------------------------------------------------ Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today and in the future. http://p.sf.net/sfu/internap-sfd2d _______________________________________________ Openhpi-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openhpi-devel
