Praveen,
My comments:
o) You changed values of OA_SOAP_INV_FZ_DEV_BAY from 0x100 to
(SAHPI_IDR_FIELDTYPE_CUSTOM + 0x101)
Which is 0x10A. And for OA_SOAP_INV_FZ_FAN_BAY, OA_SOAP_INV_FAN_SHARED,
OA_SOAP_INV_FZ_NUM too.
Is it possible that the change creates backward compatibility issues?
o) Is it possible that another plug-in (for example IPMI Direct) also will
use those values
for its own non-standard field types?
o) Suggest to rename new oh_lookup_sahpiidrfieldtype and
oh_encode_sahpiidrfieldtype function.
They definitely shall have OA SOAP mentioning in their names.
o) Suggest to move these new OA SOAP function from generic
sahpi_enum_utils.{c,h} files.
For example to sahpioasoap_enum_utils.{c,h}
o) Also the names like OH_MAX_SAHPIIDRFIELDTYPE and etc make an impression
that they are
applicable to generic SaHpi field types.
o) Keep in mind that sahpi_enum_utils.{c,h} files are auto-generated. So
the changes there shall be minimal. For example for ATCA and xTCA there
are only several lines
to be added after auto-generation.
Anton Pak
On Thu, 25 Aug 2011 14:30:59 +0400, Praveen Kumar03
<[email protected]> wrote:
> Hi,
>
>
> PFA patch for review for Bug id: 3324288-(
> http://sourceforge.net/tracker/?func=detail&aid=3324288&group_id=71730&a
> tid=532251
> <http://sourceforge.net/tracker/?func=detail&aid=3324288&group_id=71730&;
> atid=532251> ). Please review the patch and let me know your comments.
>
>
> Thanks!
>
> Praveen
>
>
>
> Information transmitted by this e-mail is proprietary to MphasiS, its
> associated companies and/ or its customers and is intended
> for use only by the individual or entity to which it is addressed, and
> may contain information that is privileged, confidential or
> exempt from disclosure under applicable law. If you are not the intended
> recipient or it appears that this mail has been forwarded
> to you without proper authority, you are notified that any use or
> dissemination of this information in any manner is strictly
> prohibited. In such cases, please notify us immediately at
> [email protected] and delete this mail from your records.
------------------------------------------------------------------------------
EMC VNX: the world's simplest storage, starting under $10K
The only unified storage solution that offers unified management
Up to 160% more powerful than alternatives and 25% more efficient.
Guaranteed. http://p.sf.net/sfu/emc-vnx-dev2dev
_______________________________________________
Openhpi-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openhpi-devel
