Anton,

Agreed. Names need to be more meaningful. Could be something like 

SAHPI_ENT_PROCESSING_BLADE
SAHPI_ENT_CONN_SWITCH
SAHPI_ENT_PROC_MEM_MODULE
SAHPI_ENT_IO_MODULE
SAHPI_ENT_PROC_IO_MODULE

How do you propose to SAF and what happens after the proposal?

Thanks
Mohan



On Wed, 2012-05-30 at 20:01 +0400, Anton Pak wrote:
> Hello!
> 
> We've encountered the following issue:
> 
> - Last IPMI-1.5 defined entity is BATTERY (0x28)
> 
> - IPMI-2.0 introduced 12 more entities: 0x29 - 0x34:
>    -- 28h Battery - last IPMI-1.5 defined entity
>    -- 29h Processing blade
>    -- 2Ah Connectivity switch
>    -- 2Bh Processor/memory module
>    -- 2Ch I/O module
>    -- 2Dh Processor/ IO module
>    -- 2Eh Management Controller Firmware
>    -- 2Fh IPMI Channel
>    -- 30h PCI Bus
>    -- 31h PCI Express Bus
>    -- 32h SCSI  Bus (parallel)
>    -- 33h SATA / SAS bus
>    -- 34h Processor / front-side bus
> 
> - SaHpi.h recognizes those entities but for 0x29 - 0x2D the names are not  
> pretty:
> 
>      SAHPI_ENT_BATTERY,
>      SAHPI_ENT_RESERVED_1,
>      SAHPI_ENT_RESERVED_2,
>      SAHPI_ENT_RESERVED_3,
>      SAHPI_ENT_RESERVED_4,
>      SAHPI_ENT_RESERVED_5,
>      SAHPI_ENT_MC_FIRMWARE,
>      SAHPI_ENT_IPMI_CHANNEL,
>      SAHPI_ENT_PCI_BUS,
>      SAHPI_ENT_PCI_EXPRESS_BUS,
>      SAHPI_ENT_SCSI_BUS,
>      SAHPI_ENT_SATA_BUS,
>      SAHPI_ENT_PROC_FSB,
>      SAHPI_ENT_CLOCK,
>      SAHPI_ENT_SYSTEM_FIRMWARE,
> 
> Suggest to change RESERVED_1-5 to more telling names.
> Perhaps it makes sense to propose this change to SAF.
> 
> What say?
> 
>       Anton Pak
> 
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and 
> threat landscape has changed and how IT managers can respond. Discussions 
> will include endpoint security, mobile security and the latest in malware 
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Openhpi-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/openhpi-devel



------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Openhpi-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openhpi-devel

Reply via email to