On Tue, Nov 02, 2004 at 08:06:47PM -0800, Roland Dreier wrote: > CONFIG_INFINIBAND_CM depends on CONFIG_BROKEN now, ... > Your patch is a small step in the right direction so I applied it.
"small" is a very generous assessment :^) It was almost irrelevant given how much code still needs work. Here's the link phase output with CM/DM/SRP/etc enabled: Building modules, stage 2. MODPOST *** Warning: "ib_client_query_cancel" [drivers/infiniband/ulp/srp/ib_srp.ko] undefined! *** Warning: "tsIbSetOutofServiceNoticeHandler" [drivers/infiniband/ulp/srp/ib_srp.ko] undefined! *** Warning: "tsIbPathRecordRequest" [drivers/infiniband/ulp/srp/ib_srp.ko] undefined! *** Warning: "tsIbSetInServiceNoticeHandler" [drivers/infiniband/ulp/srp/ib_srp.ko] undefined! *** Warning: "ib_client_mad_handler_register" [drivers/infiniband/core/ib_dm_client.ko] undefined! *** Warning: "tsIbPortInfoTblQuery" [drivers/infiniband/core/ib_dm_client.ko] undefined! *** Warning: "tsIbPortInfoQuery" [drivers/infiniband/core/ib_dm_client.ko] undefined! *** Warning: "ib_client_query" [drivers/infiniband/core/ib_dm_client.ko] undefined! *** Warning: "ib_client_alloc_tid" [drivers/infiniband/core/ib_dm_client.ko] undefined! *** Warning: "ib_mad_send" [drivers/infiniband/core/ib_cm.ko] undefined! *** Warning: "ib_mad_handler_register" [drivers/infiniband/core/ib_cm.ko] undefined! *** Warning: "ib_mad_handler_deregister" [drivers/infiniband/core/ib_cm.ko] undefined! Can folks offer some guidance on the following issues: 1) drivers/infiniband/include/ still has alot of files still prefixed with "ts". Do they all need to be renamed? Or do some need to be reworked to match some new interfaces? E.g. ib_client_query_cancel is declared in ts_ib_client_query.h. I don't know if ts_ib_client_query.h needs additional work. Should I submit patches so all #include's only reference ib_client_query.h? Or maybe just client_query.h? 2) Can some of the offending include files be dropped outright? 3) Of the ts* symbols above, can someone point me at which header file contains the "right" interfaces to use? I might be able to fixup some of the warnings above. I'm thinking of tsIbSetOutofServiceNoticeHandler and similar functions. grant _______________________________________________ openib-general mailing list [EMAIL PROTECTED] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
