On Mon, 2004-11-08 at 19:27, Sean Hefty wrote: > A couple of comments (so far) while tracing through the MAD agent code. > > * There are a couple of places where ib_get_agent_mad() will be called > multiple times in the same execution path. For example agent_send calls > it, as does agent_mad_send.
Are there others like this ? > I didn't check to see if the calls would > return the same ib_agent_port_private structure. I eliminated the duplicate call. Patch shortly on this. > (Would calling the > function ib_get_agent_port() make more sense?) Yes. > * The agent code assumes that sends are completed in the order that they > are posted. The MAD code does not guarantee that this is the case. (It > cannot do this as a result of matching requests with response, handling > timeouts, and error handling.) Since the agent does not use solicited sends, are its sends completed in order (so this is only an issue for clients using solicited sends) ? -- Hal _______________________________________________ openib-general mailing list [EMAIL PROTECTED] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
