Hello! Quoting r. Roland Dreier ([EMAIL PROTECTED]) "Re: [openib-general] [PATCH] fill in missing parameters for MAD_IFC": > I reworked this to clean a few things up and match the style of > mthca_cmd.c a little better. Does this still seem OK? > > (I got rid of the BUG_ON because I think the test > > BUG_ON((!ignore_bkey && !ignore_mkey) && !in_wc); > > is not really correct -- eg passing a MAD known not to be BM-class > with only ignore_mkey set and no in_wc would be fine -- and I > couldn't decide on a check that did seem worth oopsing for) > > Thanks, > Roland
The BUG_ON was there because of this: + if (!in_wc) + mad_flags = IB_MAD_IGNORE_ALL; so we never get to this state. mst _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
