On Sun, Feb 20, 2005 at 10:07:43AM -0800, Tom Duffy wrote: > On Sun, 2005-02-20 at 02:05 +0200, Michael S. Tsirkin wrote: > > > > I think we also should replace __inline__ with inline everywhere. > > > > Also, I think the convention is to add __ before inline functions > > if they are an implementation detail and shouldnt be called > > directly. > > That does not seem to be the case for __sdp_inet_write_space, or for > > other stuff in sdp_proto.h, so I think these functions shall have > > proper names starting with an alphanumeric. > > Yeah, I also don't like the convention of using _ in front of static > functions. Those can be updated in the next set of patches ;)
I agree, all those changes should be made to the code. There's a number of coding conventions which need to be changed to a saner form. -Libor _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
