On Sun, Feb 20, 2005 at 02:15:04AM +0200, Michael S. Tsirkin wrote: > Quoting r. Libor Michalek <[EMAIL PROTECTED]>: > > > > -int _sdp_link_path_rec_get(struct sdp_path_info *info) > > +static int _sdp_link_path_rec_get(struct sdp_path_info *info)
> Good stuff. > One comment though - one can give short names to static functions: > since they are local to file they wont conflict with anything other. > So - why prepend an "_" to the name? It was just habit, there's no good reason for the convention. I have no problem changing it. This file in particular (sdp_link.c) in the future should probably be broken out into a seperate module, since it provides IP address to PathRecord resolution using IPoIB and there are other protocols/modules which will need this functionality. -Libor _______________________________________________ openib-general mailing list [email protected] http://openib.org/mailman/listinfo/openib-general To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
